🧹 [Code Health] Fix empty catch blocks in college-scoring service - #88
🧹 [Code Health] Fix empty catch blocks in college-scoring service#88MarsLuay wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed empty catch blocks in
source/services/ai/college-scoring.service.tsby capturing the exceptions using theerrorLoggingService.💡 Why: Empty catch blocks can suppress errors silently, making debugging difficult. By explicitly logging these errors with context (e.g., category: 'ai', specific operations like 'college-scoring-articulation'), we ensure that if exceptions occur during academics score calculation, they are tracked and maintainability is improved without breaking the fallback logic.
✅ Verification: Verified the fix by successfully running the typechecker (
npm run typecheck) and the test suite (npm run test:app), with all 82 tests passing to ensure there were no regressions. Reverted any accidentalpackage-lock.jsonmodifications.✨ Result: The codebase is cleaner and adheres strictly to safe error-handling practices and project logging conventions.
PR created automatically by Jules for task 13068018570116372569 started by @MarsLuay