⚡ perf: optimize clearSelection shape querying - #122
Conversation
Change querySelectorAll to only target `.native-powerpoint-shape-selected` elements when clearing selection in `NativePowerPointView`, rather than querying all shapes and calling removeClass. This avoids unnecessary iterations over all shapes in the document when deselecting.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Changed
this.svgEl?.querySelectorAll('g[data-ooxml-shape-idx]')tothis.svgEl?.querySelectorAll('.native-powerpoint-shape-selected')insideNativePowerPointView.tsclearSelection()method.🎯 Why: The previous code iterated over every single shape on the slide (via
g[data-ooxml-shape-idx]) to remove the selection class, even for shapes that weren't selected. This is a CPU-intensive operation for slides with many shapes. By only querying for shapes that currently have the.native-powerpoint-shape-selectedclass, we eliminate unnecessary iteration overhead.📊 Measured Improvement:
Measured via
jsdomwith an SVG containing 1 selected shape out of 5, iterating 10,000 times:PR created automatically by Jules for task 6382462098759709968 started by @MarsLuay