Skip to content

🧪 Add test coverage for TextHalo.ts - #125

Open
MarsLuay wants to merge 2 commits into
mainfrom
add-text-halo-tests-3740874818002740951
Open

🧪 Add test coverage for TextHalo.ts#125
MarsLuay wants to merge 2 commits into
mainfrom
add-text-halo-tests-3740874818002740951

Conversation

@MarsLuay

@MarsLuay MarsLuay commented Sep 6, 2026

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed: Missing test file for src/TextHalo.ts
📊 Coverage: What scenarios are now tested: Color alpha compositing mathematical edge cases, parsing (hex, rgb, rgba, named, none), table structural looping to apply halos, and chart largest-area rectangle color inheritance.
Result: The improvement in test coverage: A full node:test suite running locally ensuring the module is covered and no regressions slip in for background text halos.


PR created automatically by Jules for task 3740874818002740951 started by @MarsLuay

Adds a comprehensive test suite for `src/TextHalo.ts`, covering its text halo color strategies for table grids and charts.

- Updated `load-plugin-modules.mjs` with `loadTextHaloModule`.
- Created `text-halo.test.mjs`.
- Tests alpha compositing color parsing, named colors, transparency.
- Tests area-based color inheritance for charts.
- Tests structure-based loop inheritance for tables.
Copilot AI lite review requested due to automatic review settings September 6, 2026 04:33
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Adds a comprehensive test suite for `src/TextHalo.ts`, covering its text halo color strategies for table grids and charts.

- Updated `load-plugin-modules.mjs` with `loadTextHaloModule`.
- Created `text-halo.test.mjs`.
- Tests alpha compositing color parsing, named colors, transparency.
- Tests area-based color inheritance for charts.
- Tests structure-based loop inheritance for tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants