🧪 Add test file for SlideInsertions.ts - #128
Conversation
Addresses missing unit test coverage for utility functions in `src/SlideInsertions.ts`. Added test loader module hooks in `tests/helpers/load-plugin-modules.mjs` and wrote test cases in `tests/slide-insertions.test.mjs` covering `buildDuplicateSlideOrder` and `countSlideTopLevelShapes` to ensure logical robustness.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d0a874959
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| slideInsertionsModulePromise ??= bundleSource( | ||
| "src/SlideInsertions.ts", | ||
| "slide-insertions.cjs", | ||
| ).then((outfile) => require(outfile)); |
There was a problem hiding this comment.
When either new test calls this loader, bundling src/SlideInsertions.ts pulls in pptx-svg and its renderer; this bare bundleSource call emits CommonJS without inlinePptxSvgWasmPlugin, so esbuild replaces the renderer's import.meta with an empty object and require(outfile) throws ERR_INVALID_URL while evaluating its new URL('./main.wasm', import.meta.url). The existing PresentationEngine and ShapeClipboard loaders apply this patch specifically to avoid that failure, so the new tests cannot reach their assertions under npm test until this loader does likewise.
Useful? React with 👍 / 👎.
Addresses missing unit test coverage for utility functions in `src/SlideInsertions.ts`. Added test loader module hooks in `tests/helpers/load-plugin-modules.mjs` and wrote test cases in `tests/slide-insertions.test.mjs` covering `buildDuplicateSlideOrder` and `countSlideTopLevelShapes` to ensure logical robustness.
🎯 What: Created missing test coverage for
src/SlideInsertions.ts.📊 Coverage: Specifically covers the
buildDuplicateSlideOrderarray mapping function for duplicating slides and the XML tree traversal behavior incountSlideTopLevelShapes.✨ Result: Improved overall test safety net, providing deterministic tests to help confidently refactor slide shape manipulations and XML parsing utilities moving forward.
PR created automatically by Jules for task 48146236017383794 started by @MarsLuay