Skip to content

🧪 Add missing test for processDocxEmbeds in DocxEmbedLoader - #132

Open
MarsLuay wants to merge 2 commits into
mainfrom
test-coverage-docx-embed-loader-5373107965823121422
Open

🧪 Add missing test for processDocxEmbeds in DocxEmbedLoader#132
MarsLuay wants to merge 2 commits into
mainfrom
test-coverage-docx-embed-loader-5373107965823121422

Conversation

@MarsLuay

@MarsLuay MarsLuay commented Sep 6, 2026

Copy link
Copy Markdown
Owner

🎯 What: The testing gap for processDocxEmbeds in src/DocxEmbedLoader.ts has been addressed.
📊 Coverage: The test ensures that the processDocxEmbeds function properly calls ctx.addChild() to register the DocxEmbedScanChild component.
Result: Increased unit test coverage and confidence in the Markdown post-processing embed flow.

(Note: During execution, an environment-specific missing DOCX runtime workspace issue caused several other npm test failures unrelated to this change, but the updated module test passes entirely on its own).


PR created automatically by Jules for task 5373107965823121422 started by @MarsLuay

Added a test case for the `processDocxEmbeds` function to verify that
`DocxEmbedScanChild` is correctly instantiated and added to the Markdown
post-processor context. Mocked `ownerDocument.defaultView` for the
`CoalescedTimeout` scheduling logic in the child component.
Copilot AI lite review requested due to automatic review settings September 6, 2026 04:37
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Added a test case for the `processDocxEmbeds` function to verify that
`DocxEmbedScanChild` is correctly instantiated and added to the Markdown
post-processor context. Mocked `ownerDocument.defaultView` for the
`CoalescedTimeout` scheduling logic in the child component. Also fixed
a pre-existing `provenance.json` failure in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants