Skip to content

🧪 [testing improvement] Cover remaining docxXmlText.ts functions - #137

Open
MarsLuay wants to merge 1 commit into
mainfrom
jules/add-docx-xml-text-tests-10710295744033958077
Open

🧪 [testing improvement] Cover remaining docxXmlText.ts functions#137
MarsLuay wants to merge 1 commit into
mainfrom
jules/add-docx-xml-text-tests-10710295744033958077

Conversation

@MarsLuay

@MarsLuay MarsLuay commented Sep 6, 2026

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
The file src/docxXmlText.ts only had basic unit tests statically importing and testing the decodeDocxXmlEntities function. The remaining three functions (normalizeDocxExtractedText, extractDocxTextFromXml, and extractDocxRunText) had no unit tests. Additionally, the existing test was statically importing .ts files rather than dynamically loading them via the testing harness esbuild loaders.

📊 Coverage: What scenarios are now tested

  • Added loadDocxXmlTextModule in tests/helpers/load-plugin-modules.mjs.
  • Converted all tests in tests/docx-xml-text.test.mjs to dynamically load docxXmlText.ts.
  • Added tests for normalizeDocxExtractedText confirming correct normalization of line endings, tab spaces, and whitespace trimming.
  • Added tests for extractDocxTextFromXml confirming regex tag identification (<w:t>, <w:tab/>, <w:br/>), correct decoding, and text aggregation inside <w:p> blocks.
  • Added tests for extractDocxRunText confirming regex run identification without the post-processing normalization routines.

Result: The improvement in test coverage
src/docxXmlText.ts is fully tested with high confidence, and now properly utilizes dynamic module loaders according to the project conventions.


PR created automatically by Jules for task 10710295744033958077 started by @MarsLuay

Added a dynamic loader `loadDocxXmlTextModule` in `tests/helpers/load-plugin-modules.mjs` and completely covered all functions inside `docxXmlText.ts` with tests inside `tests/docx-xml-text.test.mjs`.
Copilot AI lite review requested due to automatic review settings September 6, 2026 04:39
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants