Version Packages - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
fiber@0.16.1
Patch Changes
#97
a2b9a8cThanks @AndersRobstad! - A collection the API is rejecting no longer re-runs its loader every time youclick back into the window, and editing one no longer reaches for the keychain.
Between them those two made the app unusable after an update. Fiber is signed
ad-hoc, so a new build is a new identity and every keychain item's access list
names the old one: for one launch after every update, each credential read is a
macOS authorization dialog. That is the intended cost, and it should be one
dialog per credential.
It was not, because a failed loader run writes no cache.
loadedAtnever moved,so the collection stayed stale and the focus trigger re-ran it — and the
authorization dialog is itself a focus event, handing the window back the moment
it is dismissed. Allow, refocus, re-run, prompt again, for as long as the
credential is being refused. A failure now counts as an attempt, so the TTL
means the same thing for both outcomes: don't ask this API again for another
ttlSeconds. Refresh and Sign in again are unaffected — those are you asking.The second one arrived with the credentials file in 0.15.0. Saving a section
reconciled that file, and reconciling it means unsealing it, and unsealing it
means reading the sealing key from the keychain. Fiber saves a section on any
edit, so renaming a request could raise a password prompt. It is now reconciled
only when sharing itself moves — the switch, or which credential the collection
uses — which is what it was always for.