Open
Surface umount stderr in UnmountError; user-friendly error messages in backup/close#145
Conversation
Copilot created this pull request from a session on behalf of
MaxG87
August 16, 2026 19:31
View session
MaxG87
force-pushed
the
copilot/attach-umount-error-message
branch
3 times, most recently
from
August 17, 2026 16:42
009d093 to
22d3a50
Compare
MaxG87
force-pushed
the
copilot/attach-umount-error-message
branch
2 times, most recently
from
August 22, 2026 21:13
a384425 to
1b0e9b6
Compare
MaxG87
marked this pull request as ready for review
August 23, 2026 20:18
Users do not want to see a stack trace in case the device could not be unmounted. Instead, they'd prefer to get a useful error message without scrolling. This new feature will provide that.
…nt error Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
The receiver of the exception can decide on their own what to do about this. There is no need to formulate the error message at the error site.
MaxG87
force-pushed
the
copilot/attach-umount-error-message
branch
from
August 24, 2026 20:15
0fccedb to
0e66751
Compare
Instead of putting the complete exception to the string, only the STDERR is given now. This reduces the error message to the necessary information.
If frozen, the traceback cannot be set, which causes the error handling to crash itself.
Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
MaxG87
force-pushed
the
copilot/attach-umount-error-message
branch
from
August 25, 2026 06:45
60a8126 to
d74317e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
umountfailures previously surfaced as an unhandledUnmountErrorstack trace with no context (e.g. "target is busy" when a shell is open on the device). This change propagates theumountstderr to the user as a plain error message.shell_interface: addstderrtoShellInterfaceErrorShellInterfaceErrornow carries the stderr bytes from the underlyingCalledProcessError, defaulting tob""when output wasn't captured:Both
run_cmdandpipe_pass_cmd_to_real_cmdpopulate it on failure.storage_device_managers: propagate stderr intoUnmountErrorunmount_devicenow runsumountwithcapture_output=Trueand attaches the decoded stderr directly to theUnmountErrormessage — no moreisinstance/__cause__chain:butter_backupCLI: catchUnmountErrorinbackupandcloseBoth commands now catch
UnmountErrorand print a human-readable message to stderr instead of letting the exception propagate.backupcontinues processing remaining devices and exits with code 1 after the loop if any unmount failed.