test(lib): add coverage for propertyService filters and id lookup - #978
Merged
nanaf6203-bit merged 1 commit intoAug 31, 2026
Merged
Conversation
|
@Dataguru-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Aug 31, 2026
🔒 Preview Environment DestroyedThe preview environment for this PR has been torn down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for
propertyService.ts(the property data layer), which previously had no coverage.What's covered
searchProperties: filtering by property type, price range, location, and combined filterssearchProperties: empty-result case when no property matches the filtersgetPropertyById: valid id lookup and missing id (returnsnull)Redis, IndexedDB, and network-status checks are mocked so tests exercise the actual filter/sort/lookup logic against
MOCK_PROPERTIESrather than the caching layer. This pins the current filter contract so the mock-to-real-API migration (#13) can't silently change listing behavior.Out of scope
The properties API mock (#13) and the API route — per the issue.
Closes #929