Test/transaction service coverage - #981
Merged
nanaf6203-bit merged 2 commits intoAug 31, 2026
Merged
Conversation
|
@Dataguru-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Aug 31, 2026
🔒 Preview Environment DestroyedThe preview environment for this PR has been torn down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1
Summary
Adds test coverage for
src/lib/transactionService.ts, the API client for transaction history (GET /api/transactions). Previously only themapApiTransactionhelper had tests — the actualTransactionService.getTransactions()client itself was uncovered.What's covered
getTransactions()callsfetchwith the correct endpoint URL, and that the wallet address is properly URL-encoded.ApiTransaction[]into the app'sTransaction[]shape.{ error: "..." }body throws that exact server-provided message.fetchcall (network failure) propagates as a thrown error.All new tests use a stubbed
global.fetch— no real network calls.Why
Per the issue: this client is the mock seam for
#9(the transactions API mock). Pinning its contract now — URL, params, response mapping, and error behavior — means the upcoming mock-to-real-API migration can't silently break consumers of this client.PR 2
Summary
Adds
docs/architecture/c4-model.mdwith C4 model diagrams for the PropChain platform: a System Context diagram and a Container diagram covering the Web Client, NestJS API, Redis, PostgreSQL, and Soroban WASM contracts.Notes
MettaChain/PropChain-BackEnd); the diagram was cross-checked against its actual stack rather than assumed.BLOCKCHAIN_NETWORKShere only supports Ethereum/Polygon/BSC today. It's included per the issue's acceptance criteria as the platform's target settlement layer, with a note in the doc calling that out explicitly.Testing
N/A — documentation only. Verified both
C4ContextandC4Containerblocks parse without errors.PR 3
Summary
Add a privacy policy documenting telemetry and data collection practices across the platform.
Changes
Added docs/privacy/privacy-policy.md.
Documented handling of public wallet addresses, IP-based rate limiting, and browser cookies.
Clarified that no personal identity information (PII) is collected.
Linked the privacy policy from the frontend footer.
Validation
Verified the privacy policy is present and linked correctly from the frontend.
Closes #928
Closes #976
Closes #977