test(aes_ccm): fix incompatible-pointer-types warning in NIST vector test - #427
Open
StijnVM wants to merge 1 commit into
Open
test(aes_ccm): fix incompatible-pointer-types warning in NIST vector test#427StijnVM wants to merge 1 commit into
StijnVM wants to merge 1 commit into
Conversation
…test atcab_aes_ccm_encrypt_finish() expects a uint8_t* for the tag size, but aes_ccm_nist_vector_test() was passing the address of a size_t `taglen`, producing: atca_tests_aes_ccm.c:600:62: error: passing argument 3 of 'atcab_aes_ccm_encrypt_finish' from incompatible pointer type [-Wincompatible-pointer-types] Casting the size_t* to uint8_t* would only overwrite the low byte and leave the remaining bytes with stale content (and produce a wrong value on big-endian). Use a local uint8_t for the API call and write the result back into `taglen` so the subsequent TEST_ASSERT_EQUAL_MEMORY(expected_tag, tag, taglen) sees the length returned by the API. Signed-off-by: Stijn Van Mol <stijnvanmol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atcab_aes_ccm_encrypt_finish() expects a uint8_t* for the tag size, but aes_ccm_nist_vector_test() was passing the address of a size_t
taglen, producing:atca_tests_aes_ccm.c:600:62: error: passing argument 3 of
'atcab_aes_ccm_encrypt_finish' from incompatible pointer type
[-Wincompatible-pointer-types]
Casting the size_t* to uint8_t* would only overwrite the low byte and leave the remaining bytes with stale content (and produce a wrong value on big-endian). Use a local uint8_t for the API call and write the result back into
taglenso the subsequentTEST_ASSERT_EQUAL_MEMORY(expected_tag, tag, taglen) sees the length returned by the API.
Checklist