Skip to content

Build the committed functions snapshot before regenerating it #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estebanzimanyi merged 1 commit into from
Aug 29, 2026
Merged

Build the committed functions snapshot before regenerating it #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,25 @@ jobs:
with:
go-version: "1.23"

# The committed functions package is what a `go get` consumer compiles, and
# every step below overwrites it, so its own compilability is decided HERE
# or nowhere. Drift against the freshly derived catalog is expected and
# constant, because MobilityDB master moves independently of this repo --
# but a snapshot that no longer BUILDS is a consumer breakage, and it is
# invisible to a job that regenerates first. A retired spelling (mult_*,
# RTreeSearchOp) reaches consumers exactly this way.
- name: Build the COMMITTED functions package (what a `go get` consumer compiles)
env:
CGO_CFLAGS: -I/usr/local/include -I/usr/include/h3
CGO_LDFLAGS: -L/usr/local/lib -lmeos
LD_LIBRARY_PATH: /usr/local/lib
run: |
if ! go build ./functions; then
echo "::error::the committed functions/ snapshot does not build against this libmeos."
echo "Refresh it: python3 tools/codegen.py against a freshly derived meos-idl.json, then commit functions/."
exit 1
fi

- name: Stage the derived catalog for the generator
run: cp "${{ steps.provision.outputs.catalog-path }}" tools/meos-idl.json

Expand All @@ -54,9 +73,10 @@ jobs:

- name: Report drift between the committed and freshly derived functions package
run: |
# Informational only: CI builds and tests the FRESHLY regenerated
# functions/ above, so a drift against the committed snapshot never
# fails the build (MobilityDB master moves independently of this repo).
# Informational only, and deliberately so: MobilityDB master moves
# independently of this repo, so a difference here is ordinary and a
# contributor cannot act on it. What a stale snapshot COSTS is caught
# by the committed-snapshot build above, which fails.
# The committed functions/ is a convenience snapshot for `go get`
# consumers; refresh it by running 'python3 tools/codegen.py' against a
# freshly derived meos-idl.json and committing the result.
Expand Down
Loading