Check the tree before building it - #93
Merged
Merged
Conversation
Four states this repository can reach are invisible to a build that succeeds: build output tracked in the tree, a suite kept from running by a skip flag, a clone pinned off master or onto a fork, and a Dockerfile nothing builds. Each was found in a binding tree rather than imagined — a 5.9 MB `libmeos.so` that a local run loaded while CI loaded a freshly built one, answering for fewer families than the catalog the generator reads, is what this closes. The rules are `tools/check-tree-hygiene.py` in MEOS-API, beside the catalog and the provisioning recipe, so this repository carries no copy of them to go stale. They are their own job rather than a step of the build, because they read `git ls-files` and nothing else: a finding arrives in seconds instead of after a libmeos build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four states this repository can reach are invisible to a build that succeeds:
build output tracked in the tree, a suite kept from running by a skip flag, a
clone pinned off master or onto a fork, and a Dockerfile nothing builds. Each was
found in a binding tree rather than imagined — a 5.9 MB
libmeos.sothat a localrun loaded while CI loaded a freshly built one, answering for fewer families than
the catalog the generator reads, is what this closes.
The rules are
tools/check-tree-hygiene.pyin MEOS-API, beside the catalog andthe provisioning recipe, so this repository carries no copy of them to go stale.
They are their own job rather than a step of the build, because they read
git ls-filesand nothing else: a finding arrives in seconds instead of after alibmeos build.