Refuse a skip, and a suite that shrank - #95
Merged
estebanzimanyi merged 1 commit intoSep 1, 2026
Merged
Conversation
The build's own summary states two things this job's conclusion does not. A test reported SKIPPED asserts nothing while the job still reads success — one flag is enough to reach it, and MobilityFlink's binding module under `-Dmeos.enabled=false` reports `Tests run: 7, Failures: 0, Errors: 0, Skipped: 7` beside `BUILD SUCCESS`, its whole MEOS surface disabled under a green build. A test the run never collects is worse, because it appears in no count at all: a surefire `<excludes>`, a `-Dtest=` filter, a class renamed out of `*Test` or a deleted file all leave the skip number at zero. Once skipping is refused, removing a test is the remaining way to stop running it, so the total carries a floor. The rules live in MEOS-API beside the catalog and the tree-hygiene check, so this repository carries no copy of them. The build is teed to a log under `set -o pipefail`, so `tee` cannot mask a failing build, and the check reads the summary from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build's own summary states two things this job's conclusion does not. A test
reported SKIPPED asserts nothing while the job still reads success — one flag is
enough to reach it, and MobilityFlink's binding module under
-Dmeos.enabled=falsereportsTests run: 7, Failures: 0, Errors: 0, Skipped: 7beside
BUILD SUCCESS, its whole MEOS surface disabled under a green build.A test the run never collects is worse, because it appears in no count at all: a
surefire
<excludes>, a-Dtest=filter, a class renamed out of*Testor adeleted file all leave the skip number at zero. Once skipping is refused, removing
a test is the remaining way to stop running it, so the total carries a floor.
The rules live in MEOS-API beside the catalog and the tree-hygiene check, so this
repository carries no copy of them. The build is teed to a log under
set -o pipefail, soteecannot mask a failing build, and the check reads thesummary from it.