State the trgeometry scope the parameter types do not name - #114
Merged
estebanzimanyi merged 1 commit intoSep 2, 2026
Merged
Conversation
meta/type-scope.json declares the SQL type scope of a MEOS function whose scope MEOS itself does not state, and a public claimant of a shared PG wrapper receives only the signatures its scope covers. Ten rgeo functions serve trgeometry alone and are declared here, beside the eight restrict siblings the file already carries. Each takes its operand as a generic `const Temporal *`, which names no type, so the only parameter naming one is the second: the pose for atValue and minusValue, the timestamp for atTime and minusTime, the geometry for atGeometry and minusGeometry, the box and its border flag for atStbox and minusStbox, and the digit count for asText and asEWKT. A scope read from the parameter types therefore names the argument rather than the temporal type restricted. Four of the ten hold a wrapper whose overloads that scope did not separate. atTime and minusTime carried all twenty signatures their wrapper declares over eight claimants, atValue and minusValue both of theirs over thirteen; each now carries the one it serves, and the catalog moves in those four functions and nowhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta/type-scope.json declares the SQL type scope of a MEOS function whose
scope MEOS itself does not state, and a public claimant of a shared PG
wrapper receives only the signatures its scope covers. Ten rgeo functions
serve trgeometry alone and are declared here, beside the eight restrict
siblings the file already carries.
Each takes its operand as a generic
const Temporal *, which names notype, so the only parameter naming one is the second: the pose for
atValue and minusValue, the timestamp for atTime and minusTime, the
geometry for atGeometry and minusGeometry, the box and its border flag
for atStbox and minusStbox, and the digit count for asText and asEWKT.
A scope read from the parameter types therefore names the argument
rather than the temporal type restricted.
Four of the ten hold a wrapper whose overloads that scope did not
separate. atTime and minusTime carried all twenty signatures their
wrapper declares over eight claimants, atValue and minusValue both of
theirs over thirteen; each now carries the one it serves, and the
catalog moves in those four functions and nowhere else.