State the trgeometry scope of the third restrict verb - #115
Merged
estebanzimanyi merged 1 commit intoSep 2, 2026
Merged
Conversation
meta/type-scope.json declares atTime and minusTime for trgeometry over all three time types. deleteTime is the third verb of that trio and takes the same three, so its three functions are declared beside them. Each reads its scope from the validity check its body states, and that check names the time argument — the span, the set or the span set being deleted — rather than the temporal type the function serves. A signature is kept when the scope covers one of its arguments, so naming the time type keeps every temporal operand its wrapper declares: trgeometry_delete_tstzset answered for a tbigint as readily as for a trgeometry. The three carry one signature each after the declaration, and the catalog moves in those three functions and nowhere else. Their sibling trgeometry_delete_timestamptz already reads trgeometry and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta/type-scope.json declares atTime and minusTime for trgeometry over all
three time types. deleteTime is the third verb of that trio and takes the
same three, so its three functions are declared beside them.
Each reads its scope from the validity check its body states, and that check
names the time argument — the span, the set or the span set being deleted —
rather than the temporal type the function serves. A signature is kept when
the scope covers one of its arguments, so naming the time type keeps every
temporal operand its wrapper declares: trgeometry_delete_tstzset answered for
a tbigint as readily as for a trgeometry.
The three carry one signature each after the declaration, and the catalog
moves in those three functions and nowhere else. Their sibling
trgeometry_delete_timestamptz already reads trgeometry and is unchanged.