State the scope of the generic timestamptz-set restrictions - #117
Merged
estebanzimanyi merged 1 commit intoSep 2, 2026
Merged
Conversation
temporal_at_tstzset and temporal_minus_tstzset are generic over Temporal * and serve every temporal type, as temporal_at_values and temporal_minus_values beside them do. Their siblings state a scope through the validity check they call — temporal_at_tstzspan through a span check, temporal_delete_tstzset through a set one — and these two call none, so nothing derives a scope for them and they are declared here. The declaration is what a shared wrapper requires. Temporal_at_tstzset carries one claimant today, so nothing consults the entry and no function's signatures move; a second claimant makes it shared, and require_scopes then refuses to generate a catalog rather than let either claimant take the union.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temporal_at_tstzset and temporal_minus_tstzset are generic over Temporal *
and serve every temporal type, as temporal_at_values and temporal_minus_values
beside them do. Their siblings state a scope through the validity check they
call — temporal_at_tstzspan through a span check, temporal_delete_tstzset
through a set one — and these two call none, so nothing derives a scope for
them and they are declared here.
The declaration is what a shared wrapper requires. Temporal_at_tstzset carries
one claimant today, so nothing consults the entry and no function's signatures
move; a second claimant makes it shared, and require_scopes then refuses to
generate a catalog rather than let either claimant take the union.