Report a @csqlfn naming a wrapper over another container - #118
Merged
estebanzimanyi merged 1 commit intoSep 2, 2026
Merged
Conversation
A MEOS function's name ends in the container it takes, and its @csqlfn names the PG wrapper it corresponds to. Where the two disagree about the container, every existing check still passes: the wrapper exists, nothing is unreachable, and the arity matches. What the catalog then derives is the SQL surface of a different overload, so lint_container_family_csqlfn reports the disagreement beside the ever/always, positional and case lints run over the same map. Reading the suffixes literally reports the tree rather than a defect. A concrete function name over a generic wrapper is how the value surface is written throughout — adjacent_span_timestamptz names Adjacent_span_value because one wrapper serves every base type — and forty names disagree that way. Both sides are therefore read as a container family, mapping tstzset to set and timestamptz to value, which leaves the seven that named a wrapper over another container and which MobilityDB now corrects. The lint reports none against a MobilityDB tree carrying that correction. Its test states the case it must catch and four it must not, and neutering the comparison fails the first while leaving the others passing, so the suite discriminates the lint rather than agreeing with it either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A MEOS function's name ends in the container it takes, and its @csqlfn names
the PG wrapper it corresponds to. Where the two disagree about the container,
every existing check still passes: the wrapper exists, nothing is unreachable,
and the arity matches. What the catalog then derives is the SQL surface of a
different overload, so lint_container_family_csqlfn reports the disagreement
beside the ever/always, positional and case lints run over the same map.
Reading the suffixes literally reports the tree rather than a defect. A
concrete function name over a generic wrapper is how the value surface is
written throughout — adjacent_span_timestamptz names Adjacent_span_value
because one wrapper serves every base type — and forty names disagree that
way. Both sides are therefore read as a container family, mapping tstzset to
set and timestamptz to value, which leaves the seven that named a wrapper over
another container and which MobilityDB now corrects.
The lint reports none against a MobilityDB tree carrying that correction. Its
test states the case it must catch and four it must not, and neutering the
comparison fails the first while leaving the others passing, so the suite
discriminates the lint rather than agreeing with it either way.