Build the wrappers the tree carries rather than regenerating them - #18
Merged
estebanzimanyi merged 1 commit intoSep 1, 2026
Conversation
The image regenerated the wrappers on the way to compiling them, which needs a catalog. The catalog is derived from MobilityDB rather than committed, so it is not in the tree the build context carries, and `npm run generate` stops on the file it cannot find. The workflow does not meet this because it stages a derived catalog before generating; `docker build` from a clean checkout has no such step. So the image takes the committed wrappers instead. That is also the question this build is worth asking: those wrappers are what a consumer of the published package compiles, and whether they still build against the MEOS they are linked to is decided here or nowhere, since regenerating first overwrites the evidence. Node goes with the generate step, its only use in this stage, and `bindings.c` comes out of `.dockerignore` because the image now consumes it rather than produces it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image regenerated the wrappers on the way to compiling them, which needs a
catalog. The catalog is derived from MobilityDB rather than committed, so it is
not in the tree the build context carries, and
npm run generatestops on thefile it cannot find. The workflow does not meet this because it stages a derived
catalog before generating;
docker buildfrom a clean checkout has no such step.So the image takes the committed wrappers instead. That is also the question this
build is worth asking: those wrappers are what a consumer of the published
package compiles, and whether they still build against the MEOS they are linked
to is decided here or nowhere, since regenerating first overwrites the evidence.
Node goes with the generate step, its only use in this stage, and
bindings.ccomes out of
.dockerignorebecause the image now consumes it rather thanproduces it.