Compile for Wasm on the event that gates review - #362
Merged
estebanzimanyi merged 1 commit intoSep 3, 2026
Conversation
A pull request excludes all three emscripten cross-compiles, so a change that does not build for Wasm is found on the push to main that follows its merge rather than on the pull request itself. wasm_mvp is kept on a pull request, leaving main the first event to compile only the two targets a reduced matrix would drop anyway. Naming wasm_eh and wasm_threads in the exclusion is what states that intent, and it is all it does: `run_in_reduced_ci_mode` is true for wasm_mvp alone, so the reduced matrix a pull request already enables filters the other two whether or not the exclusion lists them. Running the matrix parser over its own distribution matrix answers with the one job the change adds: exclusion before -> wasm targets [] exclusion after -> wasm targets ['wasm_mvp'] linux targets -> ['linux_amd64'], unchanged Both remaining targets still build on push to main and on workflow_dispatch, where the full matrix runs ahead of a release, so the coverage lost is a duplicate of what a pull request now carries. The MEOS port rebuilds libmeos and its heavy dependencies from source on each job, which is why a pull request pays for one Wasm target rather than three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request excludes all three emscripten cross-compiles, so a change that
does not build for Wasm is found on the push to main that follows its merge
rather than on the pull request itself. wasm_mvp is kept on a pull request,
leaving main the first event to compile only the two targets a reduced matrix
would drop anyway.
Naming wasm_eh and wasm_threads in the exclusion is what states that intent,
and it is all it does:
run_in_reduced_ci_modeis true for wasm_mvp alone, sothe reduced matrix a pull request already enables filters the other two whether
or not the exclusion lists them. Running the matrix parser over its own
distribution matrix answers with the one job the change adds:
exclusion before -> wasm targets []
exclusion after -> wasm targets ['wasm_mvp']
linux targets -> ['linux_amd64'], unchanged
Both remaining targets still build on push to main and on workflow_dispatch,
where the full matrix runs ahead of a release, so the coverage lost is a
duplicate of what a pull request now carries. The MEOS port rebuilds libmeos
and its heavy dependencies from source on each job, which is why a pull request
pays for one Wasm target rather than three.