Skip to content

feat: seal of reliability description page - #178

Open
Alessandro100 wants to merge 15 commits into
mainfrom
feat/166-seal-of-reliability-description
Open

feat: seal of reliability description page#178
Alessandro100 wants to merge 15 commits into
mainfrom
feat/166-seal-of-reliability-description

Conversation

@Alessandro100

Copy link
Copy Markdown
Contributor

Summary:

closes #166

  • Introduces the seal of reliability static description page
  • Consolidates styling components for a more consistent app and better reuse

Expected behavior:

When going to the seal of reliability description page, you should be able to see all the information in a clear manner in any resolution and in light mode / dark mode

Testing tips:

Go to /seal-of-reliability and check the page out in dark mode, mobile, check the spelling etc

Important to note

  • The official seal png is not done and we are curently using a placeholder in the meantime
  • The button in the header is not able to link to the seal page just yet
  • and the icons for criteria are not available yet -> lock icons for now

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with yarn test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
Screenshot 2026-08-12 at 14 30 20 Screenshot 2026-08-12 at 14 30 28 Screenshot 2026-08-12 at 14 30 39

@Alessandro100
Alessandro100 requested a balanced review from Copilot August 12, 2026 18:32
@Alessandro100 Alessandro100 self-assigned this Aug 12, 2026
@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mobilitydatabase-web Ready Ready Preview Aug 14, 2026 1:51pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a static Seal of Reliability information page and consolidates reusable layout/card styling. Applied the Vercel React best-practices guidance.

Changes:

  • Adds the Seal description, criteria, benefits, grace periods, and FAQ.
  • Adds a feature-flagged footer link and translations.
  • Extracts reusable section, card-title, and accordion styling.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
src/app/Theme.ts Adds the section card variant.
src/app/styles/PageLayout.style.ts Removes the superseded container style.
src/app/screens/FeedSubmissionFAQ.tsx Uses shared accordion styling.
src/app/screens/Feeds/FeedsScreenSkeleton.tsx Uses the shared section container.
src/app/screens/Feed/FeedSummary.styles.ts Removes extracted card styles.
src/app/screens/Feed/components/FeedSummary.tsx Uses shared card and title styling.
src/app/screens/FAQ.tsx Uses the shared section container.
src/app/interface/RemoteConfig.ts Adds the Seal feature flag.
src/app/components/SectionContainer.tsx Introduces a reusable page section container.
src/app/components/Footer.tsx Adds the feature-flagged Seal link.
src/app/components/CardSectionTitle.tsx Introduces reusable card headings.
src/app/components/accordionStyle.ts Centralizes accordion styling.
src/app/[locale]/seal-of-reliability/page.tsx Defines the static route and metadata.
src/app/[locale]/seal-of-reliability/lib/content.tsx Defines page content and criteria data.
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx Implements the Seal description UI.
src/app/[locale]/feeds/components/FeedsScreen.tsx Adopts the shared section container.
src/app/[locale]/contribute/FeedSubmission/FeedSubmission.tsx Adopts the shared section container.
src/app/[locale]/about/components/AboutPage.tsx Adopts the shared section container.
messages/fr.json Adds French footer and Seal strings.
messages/en.json Adds English footer and Seal strings.
Suppressed comments (3)

src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx:163

  • This section heading should be an h2 beneath the page h1; rendering it as h6 skips heading levels while its child card headings are h3. Preserve the visual variant and set component='h2'.
          variant='h6'

src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx:197

  • This section heading should be an h2 beneath the page h1 rather than skipping directly to h6. The visual styling can remain h6 by setting the semantic component separately.
          variant='h6'

src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx:279

  • This section heading also skips from the page h1 to h6, which makes heading navigation misleading. Render it as h2 while retaining the h6 variant for appearance.
          variant='h6'

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/app/components/SectionContainer.tsx Outdated
Comment thread src/app/components/CardSectionTitle.tsx Outdated
Comment thread src/app/components/Footer.tsx
Comment on lines +54 to +58
<Box sx={{ width: { xs: '100%', md: '55%' } }}>
<Typography variant='h1' sx={{ mb: 2 }}>
{heroContent.title}
</Typography>
{heroContent.paragraphs.map((paragraph) => (
Comment thread messages/en.json Outdated
Comment thread src/app/[locale]/seal-of-reliability/lib/content.tsx Outdated
Comment thread src/app/[locale]/seal-of-reliability/page.tsx Outdated
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 89 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 74 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 30 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 95 🟠 84 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 99 🟢 94 🟢 96 🟢 100

Alessandro100 and others added 3 commits August 12, 2026 15:05
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread messages/en.json
"hero": {
"title": "The Benchmark for Reliable GTFS Schedule Data",
"paragraphs": [
"It's hard to measure if data is trustworthy. Transit agencies struggle to know if their GTFS data works for riders; data vendors lack a baseline bar of quality to aspire to, and trip planning apps end up spending time pre-processing feeds rather than seamlessly consuming them",

@jcpitre jcpitre Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but isbaseline bar not a bit redundant? I suggest only baseline
@emmambd @abigailmbd

Suggested change
"It's hard to measure if data is trustworthy. Transit agencies struggle to know if their GTFS data works for riders; data vendors lack a baseline bar of quality to aspire to, and trip planning apps end up spending time pre-processing feeds rather than seamlessly consuming them",
"It's hard to measure if data is trustworthy. Transit agencies struggle to know if their GTFS data works for riders; data vendors lack a baseline of quality to aspire to, and trip planning apps end up spending time pre-processing feeds rather than seamlessly consuming them",

Comment thread messages/en.json
},
"gracePeriods": {
"title": "Grace periods",
"description": "Temporary issues won't immediately cost an agency its Seal. The following windows apply per violation type.",

@jcpitre jcpitre Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but agencies don't have seals. Feeds have.
@emmambd @abigailmbd

@jcpitre jcpitre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks. But approved. Tested both themes, and on my cell.

Unrelated to this PR, but you should think of replacing Company with Organization at the bottom of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GTFS Seal of Reliability description page

3 participants