feat: seal of reliability description page - #178
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a static Seal of Reliability information page and consolidates reusable layout/card styling. Applied the Vercel React best-practices guidance.
Changes:
- Adds the Seal description, criteria, benefits, grace periods, and FAQ.
- Adds a feature-flagged footer link and translations.
- Extracts reusable section, card-title, and accordion styling.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
src/app/Theme.ts |
Adds the section card variant. |
src/app/styles/PageLayout.style.ts |
Removes the superseded container style. |
src/app/screens/FeedSubmissionFAQ.tsx |
Uses shared accordion styling. |
src/app/screens/Feeds/FeedsScreenSkeleton.tsx |
Uses the shared section container. |
src/app/screens/Feed/FeedSummary.styles.ts |
Removes extracted card styles. |
src/app/screens/Feed/components/FeedSummary.tsx |
Uses shared card and title styling. |
src/app/screens/FAQ.tsx |
Uses the shared section container. |
src/app/interface/RemoteConfig.ts |
Adds the Seal feature flag. |
src/app/components/SectionContainer.tsx |
Introduces a reusable page section container. |
src/app/components/Footer.tsx |
Adds the feature-flagged Seal link. |
src/app/components/CardSectionTitle.tsx |
Introduces reusable card headings. |
src/app/components/accordionStyle.ts |
Centralizes accordion styling. |
src/app/[locale]/seal-of-reliability/page.tsx |
Defines the static route and metadata. |
src/app/[locale]/seal-of-reliability/lib/content.tsx |
Defines page content and criteria data. |
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx |
Implements the Seal description UI. |
src/app/[locale]/feeds/components/FeedsScreen.tsx |
Adopts the shared section container. |
src/app/[locale]/contribute/FeedSubmission/FeedSubmission.tsx |
Adopts the shared section container. |
src/app/[locale]/about/components/AboutPage.tsx |
Adopts the shared section container. |
messages/fr.json |
Adds French footer and Seal strings. |
messages/en.json |
Adds English footer and Seal strings. |
Suppressed comments (3)
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx:163
- This section heading should be an
h2beneath the pageh1; rendering it ash6skips heading levels while its child card headings areh3. Preserve the visual variant and setcomponent='h2'.
variant='h6'
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx:197
- This section heading should be an
h2beneath the pageh1rather than skipping directly toh6. The visual styling can remainh6by setting the semantic component separately.
variant='h6'
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx:279
- This section heading also skips from the page
h1toh6, which makes heading navigation misleading. Render it ash2while retaining theh6variant for appearance.
variant='h6'
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <Box sx={{ width: { xs: '100%', md: '55%' } }}> | ||
| <Typography variant='h1' sx={{ mb: 2 }}> | ||
| {heroContent.title} | ||
| </Typography> | ||
| {heroContent.paragraphs.map((paragraph) => ( |
|
*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/ * (Desktop)
*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds * (Desktop)
*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-bmg12ryhx-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| "hero": { | ||
| "title": "The Benchmark for Reliable GTFS Schedule Data", | ||
| "paragraphs": [ | ||
| "It's hard to measure if data is trustworthy. Transit agencies struggle to know if their GTFS data works for riders; data vendors lack a baseline bar of quality to aspire to, and trip planning apps end up spending time pre-processing feeds rather than seamlessly consuming them", |
There was a problem hiding this comment.
Nitpick, but isbaseline bar not a bit redundant? I suggest only baseline
@emmambd @abigailmbd
| "It's hard to measure if data is trustworthy. Transit agencies struggle to know if their GTFS data works for riders; data vendors lack a baseline bar of quality to aspire to, and trip planning apps end up spending time pre-processing feeds rather than seamlessly consuming them", | |
| "It's hard to measure if data is trustworthy. Transit agencies struggle to know if their GTFS data works for riders; data vendors lack a baseline of quality to aspire to, and trip planning apps end up spending time pre-processing feeds rather than seamlessly consuming them", |
| }, | ||
| "gracePeriods": { | ||
| "title": "Grace periods", | ||
| "description": "Temporary issues won't immediately cost an agency its Seal. The following windows apply per violation type.", |
There was a problem hiding this comment.
Nitpick, but agencies don't have seals. Feeds have.
@emmambd @abigailmbd
jcpitre
left a comment
There was a problem hiding this comment.
Two nitpicks. But approved. Tested both themes, and on my cell.
Unrelated to this PR, but you should think of replacing Company with Organization at the bottom of the page.
Summary:
closes #166
Expected behavior:
When going to the seal of reliability description page, you should be able to see all the information in a clear manner in any resolution and in light mode / dark mode
Testing tips:
Go to
/seal-of-reliabilityand check the page out in dark mode, mobile, check the spelling etcImportant to note
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything