Skip to content

fix(selftest): make timeout-minutes assertion validate jobs instead of file text (closes #590) - #593

Merged
d-morrison merged 2 commits into
mainfrom
fix/selftest-timeout-minutes-assertion-590
Aug 24, 2026
Merged

fix(selftest): make timeout-minutes assertion validate jobs instead of file text (closes #590)#593
d-morrison merged 2 commits into
mainfrom
fix/selftest-timeout-minutes-assertion-590

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Closes #590

WIP — opened up front to claim the issue; implementing now.

@d-morrison
d-morrison marked this pull request as ready for review August 24, 2026 00:35
@d-morrison

Copy link
Copy Markdown
Collaborator Author

@claude review

@github-actions

Copy link
Copy Markdown
Contributor

👀 Picked up by workflow run #32677139797. Setup runs first; Claude itself responds after that.

@github-actions

Copy link
Copy Markdown
Contributor

Warning

No review ran --- this PR edits .github/workflows/_selftest.yml.
claude-code-action requires workflow files to match the default branch on dispatched runs, so its token exchange fails until this change merges.
The review is skipped by design, and re-running or re-dispatching will not change that: the skip lifts only if the PR stops editing that file.

require-review reports a gray skipped rather than green.
A green there attests that a reviewer ran, never that one approved; here none ran at all.
Merge on a self-review or a human review instead.

View run

@d-morrison
d-morrison merged commit 8a4fc79 into main Aug 24, 2026
48 of 50 checks passed
@d-morrison
d-morrison deleted the fix/selftest-timeout-minutes-assertion-590 branch August 24, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_selftest's timeout-minutes assertion is satisfied by comment text, so it is vacuous for caller workflows

1 participant