config(flash-sac): enable full-objective compile - #1641
Merged
TATP-233 merged 1 commit intoSep 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable FlashSAC full-objective compilation in the UniLab owner configuration.
The configuration now sets:
Manual actor and critic CUDA Graph switches remain disabled by default.
Why
The corresponding
unilab_rlimplementation extends FlashSAC compilation from loss-only helpers to the complete critic and actor objectives.This allows Inductor to optimize:
The full-objective compile path is the recommended production configuration because it provides most of the measured performance improvement while avoiding the additional lifecycle complexity of an outer manual CUDA Graph.
Performance Reference
Measured on an NVIDIA RTX 4090 with PyTorch 2.8.0+cu128, BF16 AMP, batch size 2048, and G1-like dimensions 98/101/29.
The full-objective compile path reduces mean learner-round time by approximately 63.1% compared with deferred eager execution in the learner microbenchmark.
Dependency Requirement
This configuration requires a
unilab_rlversion that contains thecompile_full_objectivesFlashSAC implementation and builder forwarding.The
unilab_rlimplementation should therefore be merged and released before this configuration is enabled in the default UniLab installation.Validation
unilab_rlfocused tests passed.Full benchmark data and reproduction instructions are available in:
https://github.com/EtherealTide/UniLab-FlashSAC-Optmization