Skip to content

Migrate calo calibration modules from CaloCalibration repository - #1936

Open
giro94 wants to merge 3 commits into
Mu2e:mainfrom
giro94:dev
Open

Migrate calo calibration modules from CaloCalibration repository#1936
giro94 wants to merge 3 commits into
Mu2e:mainfrom
giro94:dev

Conversation

@giro94

@giro94 giro94 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

For now, cosmics and noise modules moved over.
Source and combination will follow later.

The idea is to move here anything that must run at online level or in Pass-1/2/N steps.
Anything else can remain in the separate repo.

@giro94
giro94 requested a review from sophiemiddleton August 21, 2026 11:02
@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @giro94,
You have proposed changes to files in these packages:

  • CaloCalibration
  • /

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for c41473e: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@giro94

giro94 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Unsure if we should keep the inner directory structure (CosmicsCalib, NoiseAnalysis, etc), or we should flatten everything into inc/src/fcl directories. @brownd1978

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at c41473e.

Test Result Details
test with Command did not list any other PRs to include
merge Merged c41473e at 0878d6b
build (prof) Log file. Build time: 04 min 26 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 4 files
clang-tidy ➡️ 8 errors 942 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at c41473e after being merged into the base branch at 0878d6b.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants