Migrate calo calibration modules from CaloCalibration repository - #1936
Open
giro94 wants to merge 3 commits into
Open
Migrate calo calibration modules from CaloCalibration repository#1936giro94 wants to merge 3 commits into
giro94 wants to merge 3 commits into
Conversation
Collaborator
Author
|
Unsure if we should keep the inner directory structure (CosmicsCalib, NoiseAnalysis, etc), or we should flatten everything into inc/src/fcl directories. @brownd1978 |
Collaborator
|
☀️ The build tests passed at c41473e.
N.B. These results were obtained from a build of this Pull Request at c41473e after being merged into the base branch at 0878d6b. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, cosmics and noise modules moved over.
Source and combination will follow later.
The idea is to move here anything that must run at online level or in Pass-1/2/N steps.
Anything else can remain in the separate repo.