Skip to content

Add MDC2020.fcl, a single detector-configuration epilog - #570

Merged
oksuzian merged 1 commit into
mainfrom
mdc2020-era-epilog
Aug 20, 2026
Merged

Add MDC2020.fcl, a single detector-configuration epilog#570
oksuzian merged 1 commit into
mainfrom
mdc2020-era-epilog

Conversation

@oksuzian

Copy link
Copy Markdown
Collaborator

Geometry and CRV set together, in the shape Run1B.fcl established. The MDC2020 geometry carries crv_counters_v09 and its 25 CRV sectors; selecting one without the other produces a job that runs and is wrong.

It works by winning on order rather than by changing anything: emitted after the base FCL, it lands after digitize/epilog.fcl and reco/epilog.fcl and overwrites the Run1A CRV values those pull in. No existing file is modified and no current-era job is affected -- verified by dumping seven entry points with and without the new file and diffing the resolved era keys.

Requires the Offline CRV MDC2020 epilogs to merge first.

Verified against the MDC2020 branch: identical resolved config for digitize/OnSpill, digitize/OffSpill, mixing/Mix, reco/OnSpill, reco/NoField, recoMC/OnSpill and recoMC/NoField.

Geometry and CRV set together, in the shape Run1B.fcl established. The MDC2020
geometry carries crv_counters_v09 and its 25 CRV sectors; selecting one
without the other produces a job that runs and is wrong.

It works by winning on order rather than by changing anything: emitted after
the base FCL, it lands after digitize/epilog.fcl and reco/epilog.fcl and
overwrites the Run1A CRV values those pull in. No existing file is modified
and no current-era job is affected -- verified by dumping seven entry points
with and without the new file and diffing the resolved era keys.

Requires the Offline CRV MDC2020 epilogs to merge first.

Verified against the MDC2020 branch: identical resolved config for
digitize/OnSpill, digitize/OffSpill, mixing/Mix, reco/OnSpill, reco/NoField,
recoMC/OnSpill and recoMC/NoField.
@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @oksuzian,
You have proposed changes to files in these packages:

  • JobConfig

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for bd8292f: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@oksuzian oksuzian changed the title feat(config): add MDC2020.fcl, a single detector-configuration epilog Add MDC2020.fcl, a single detector-configuration epilog Aug 19, 2026
@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at bd8292f.

Test Result Details
test with Command did not list any other PRs to include
merge Merged bd8292f at 9d4106e
build (prof) Log file. Build time: 04 min 21 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at bd8292f after being merged into the base branch at 9d4106e.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian
oksuzian requested review from rlcee and a lite review from Copilot and removed request for Copilot August 19, 2026 16:20
@oksuzian
oksuzian merged commit 56e87eb into main Aug 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants