Add MDC2020.fcl, a single detector-configuration epilog - #570
Merged
Conversation
Geometry and CRV set together, in the shape Run1B.fcl established. The MDC2020 geometry carries crv_counters_v09 and its 25 CRV sectors; selecting one without the other produces a job that runs and is wrong. It works by winning on order rather than by changing anything: emitted after the base FCL, it lands after digitize/epilog.fcl and reco/epilog.fcl and overwrites the Run1A CRV values those pull in. No existing file is modified and no current-era job is affected -- verified by dumping seven entry points with and without the new file and diffing the resolved era keys. Requires the Offline CRV MDC2020 epilogs to merge first. Verified against the MDC2020 branch: identical resolved config for digitize/OnSpill, digitize/OffSpill, mixing/Mix, reco/OnSpill, reco/NoField, recoMC/OnSpill and recoMC/NoField.
Collaborator
|
☀️ The build tests passed at bd8292f.
N.B. These results were obtained from a build of this Pull Request at bd8292f after being merged into the base branch at 9d4106e. For more information, please check the job page here. |
oksuzian
requested review from
rlcee
and
a lite review from Copilot
and removed request for
Copilot
August 19, 2026 16:20
rlcee
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geometry and CRV set together, in the shape Run1B.fcl established. The MDC2020 geometry carries crv_counters_v09 and its 25 CRV sectors; selecting one without the other produces a job that runs and is wrong.
It works by winning on order rather than by changing anything: emitted after the base FCL, it lands after digitize/epilog.fcl and reco/epilog.fcl and overwrites the Run1A CRV values those pull in. No existing file is modified and no current-era job is affected -- verified by dumping seven entry points with and without the new file and diffing the resolved era keys.
Requires the Offline CRV MDC2020 epilogs to merge first.
Verified against the MDC2020 branch: identical resolved config for digitize/OnSpill, digitize/OffSpill, mixing/Mix, reco/OnSpill, reco/NoField, recoMC/OnSpill and recoMC/NoField.