fix: complete OrbitStack qualifying tasks - #4
Open
sanjay-sanju-03 wants to merge 2 commits into
Open
Conversation
Task 1 - Fix pricing logic bug (calculator.ts) Pro user above threshold + stackable free-shipping coupon was incorrectly adding STANDARD_SHIPPING_RATE to discountCents even though shipping was already zeroed by the Pro threshold. Fix: gate on !proThresholdFreeShipping. Added tests/pricing.test.ts with 6 cases covering all tier/coupon combos. Task 2 - Fix N+1 query (queries.ts) listOrders() was firing one OrderItem.findMany per order. Replaced with Prisma nested include to eliminate per-order round-trips. Task 3 - Duplicate Order feature POST /api/orders/[id]/duplicate: ownership at DB level, validates active status and full-quantity stock, returns items+quantities and skipped list. DuplicateOrderButton.tsx: client island with loading/success/error states. OrderCard.tsx: renders DuplicateOrderButton in card footer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed Tasks
Task 1 — Pricing Logic
Task 2 — Dashboard Performance
Task 3 — Duplicate Order
Validation