Skip to content

Add nvskills workflow file - #283

Open
ohadmo wants to merge 1 commit into
mainfrom
omosafi/nvskills
Open

Add nvskills workflow file#283
ohadmo wants to merge 1 commit into
mainfrom
omosafi/nvskills

Conversation

@ohadmo

@ohadmo ohadmo commented Aug 26, 2026

Copy link
Copy Markdown

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo ohadmo self-assigned this Aug 26, 2026
@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds a reusable-workflow request configuration for NVSkills CI, triggered by pull-request activity, an /nvskills-ci comment, or signed bot pushes.

  • Grants read-only repository permissions and forwards the NVSkills dispatch token.
  • Places the workflow at the repository root, where GitHub Actions will not discover it.

Confidence Score: 4/5

The PR should not merge until the workflow is moved under .github/workflows/, because its current location makes the added CI integration inert.

GitHub Actions does not discover root-level workflow files, so none of the configured pull-request, comment, or push triggers can execute the NVSkills request job.

Files Needing Attention: request-nvskills-ci.yml

Important Files Changed

Filename Overview
request-nvskills-ci.yml Adds the NVSkills trigger workflow, but its root-level location prevents GitHub Actions from registering or running it.

Reviews (1): Last reviewed commit: "Add nvskills workflow file" | Re-trigger Greptile

Comment thread request-nvskills-ci.yml
@@ -0,0 +1,26 @@
name: Request NVSkills CI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Workflow is not discoverable

Because this workflow file is at the repository root instead of under .github/workflows/, GitHub Actions does not register it, causing the pull-request, /nvskills-ci comment, and push triggers to never run the NVSkills request job.

Knowledge Base Used: Build configuration and CI

@ohadmo

ohadmo commented Aug 26, 2026

Copy link
Copy Markdown
Author

/nvskills-ci

@evasnow1992

Copy link
Copy Markdown
Collaborator

Hi Ohad, thank you for adding the nvSkill workflow. Kevin is currently OOO and will complete the review when he's back. In the meantime, I also took a look at the changes and have a couple of general comments:

  1. I think the issue Greptile raised is valid: the YAML file needs to be under .github/workflows/ for the workflow to be triggered.
  2. The file is also missing the SPDX header required for our repo:
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants