Skip to content

fix(core): pointer solid icon - #272

Open
coryrylan wants to merge 4 commits into
mainfrom
topic-icon-solid-fix
Open

fix(core): pointer solid icon#272
coryrylan wants to merge 4 commits into
mainfrom
topic-icon-solid-fix

Conversation

@coryrylan

@coryrylan coryrylan commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Updated the server-rendered pointer-solid icon with a filled appearance and tighter alignment.
    • Corrected formatted byte units to use standard capitalization, including kB, MB, KiB, and MiB.
    • Updated displayed unit labels and documentation to match the revised capitalization consistently across formatting options.
    • Applied consistent unit formatting across automatic, forced-unit, locale-sensitive, precision, sign, zero-value, and large-value scenarios.

@coryrylan coryrylan self-assigned this Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 72e0a46a-3c9e-47ca-a734-cad0d52807e1

📥 Commits

Reviewing files that changed from the base of the PR and between 8868c12 and de83be8.

📒 Files selected for processing (5)
  • projects/core/src/dropzone/dropzone.css
  • projects/core/src/dropzone/dropzone.ts
  • projects/core/src/progress-ring/progress-ring.css
  • projects/core/src/progress-ring/progress-ring.test.ts
  • projects/core/src/progress-ring/progress-ring.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The byte formatter now uses capitalized SI and IEC unit labels. The dropzone and progress ring use prefixed CSS classes. The SSR pointer-solid icon uses a filled mask-based SVG. Lighthouse JavaScript bundle-size thresholds also increase.

Changes

Byte formatting capitalization

Layer / File(s) Summary
Update byte-unit labels
projects/core/src/format-bytes/format-bytes.ts, projects/core/src/format-bytes/format-bytes.test.ts, projects/core/src/format-bytes/format-bytes.test.ssr.ts
The formatter uses kB, MB, KiB, and related capitalized units. Documentation and formatting tests use the updated labels.

Component class names

Layer / File(s) Summary
Rename dropzone classes
projects/core/src/dropzone/dropzone.css, projects/core/src/dropzone/dropzone.ts
The dropzone markup and CSS use prefixed border and text classes. Existing styles remain unchanged.
Rename progress ring class
projects/core/src/progress-ring/progress-ring.ts, projects/core/src/progress-ring/progress-ring.css, projects/core/src/progress-ring/progress-ring.test.ts
The progress ring uses progress-ring-circle instead of ring in markup, CSS selectors, animation rules, and tests.

SSR icon rendering

Layer / File(s) Summary
Update pointer-solid SVG
projects/core/src/icon/server.ts
The SSR icon registry uses a filled mask-based SVG with viewBox="4 4 17 17" instead of the previous outlined SVG.

Lighthouse threshold

Layer / File(s) Summary
Raise bundle-size thresholds
projects/core/src/index.test.lighthouse.ts
The JavaScript bundle-size limit increases to 109.1 KB. The compressed JavaScript imports limit increases to 90 KB.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to de83b

The component class-name updates retain matching styles and tests, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 8 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the pointer-solid icon fix, which is a real and specific change in the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 8 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch topic-icon-solid-fix

Comment @coderabbitai help to get the list of available commands.

@coryrylan
coryrylan force-pushed the topic-icon-solid-fix branch 7 times, most recently from de83be8 to 6040ac8 Compare September 3, 2026 14:55
- avoid tailwind specific classes in implementations

Signed-off-by: Cory Rylan <crylan@nvidia.com>
- add missing slot metadata documentation

Signed-off-by: Cory Rylan <crylan@nvidia.com>
-  correct casing to SI to IEC display format

Signed-off-by: Cory Rylan <crylan@nvidia.com>
Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan
coryrylan force-pushed the topic-icon-solid-fix branch from 6040ac8 to 389aa2b Compare September 3, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant