chore(lint): cover select slot exception and drop dead branch - #274
Open
cursor[bot] wants to merge 1 commit into
Open
chore(lint): cover select slot exception and drop dead branch#274cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Adds hasSlot coverage for the nve-select exception and removes the unreachable tagName === 'default' recommendation branch. Line coverage rises from 88.88% to 100% and branch coverage from 75% to 100%. No public API change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage upkeep selected by
select-task.js.Rationale (selector): "2 uncovered lines, 88.88% lines and 75% branches, the smallest gap below the 90% threshold"
Target:
projects/lint/src/eslint/internals/slots.tsMeasurement
Changes:
hasSlot('nve-select', …)so the documented exception path is exercised.tagName === 'default' && hasUnnamedSlotrecommendation branch. No element is nameddefault, so that assignment was unreachable with current metadata.API
No public API changed. Exported function names, signatures, and return types are unchanged. No custom element tags, properties, attributes, slots, events, CSS custom properties, or CSS parts were edited.
Left alone
hasDefaultSlot,isKnownElement) already at 100% via rule tests.Validation
projects/lint:lintpass;test416 passed;test:coveragerefreshed.test:types,test:axe,test:ssr,test:lighthouse,test:visualare not defined for@nvidia-elements/lint.mise exec -- pnpm run cipass;git diff --checkclean on the committed files.