Skip to content

Fix[precompiled-arm]: Use oci: directory transport with --all flag instead of oci-archive #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivakunv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix[precompiled-arm]: Use oci: directory transport with --all flag instead of oci-archive #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/precompiled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,9 +492,29 @@ jobs:
if: steps.set_image_vars.outputs.run_publish == 'true'
run: |
image_path="./driver-images-${{ matrix.driver_branch }}-${{ env.KERNEL_VERSION }}.tar"
IMAGE="${PRIVATE_REGISTRY}/nvidia/driver:${{ matrix.driver_branch }}-${{ env.KERNEL_VERSION }}"
echo "uploading $image_path"
if [[ "${{ github.ref == 'refs/heads/main' }}" == "true" ]]; then
skopeo copy --authfile "${REGISTRY_AUTH_FILE}" "oci-archive:${image_path}" docker://${PRIVATE_REGISTRY}/nvidia/driver:${{ matrix.driver_branch }}-${{ env.KERNEL_VERSION }}
mkdir -p /tmp/oci-image
tar -xf "${image_path}" -C /tmp/oci-image
skopeo copy --all --authfile "${REGISTRY_AUTH_FILE}" "oci:/tmp/oci-image" docker://${IMAGE}

# Verify published manifest matches the built OCI artifact by comparing
# platform digests — ensures skopeo copy pushed all manifests correctly
LOCAL=$(skopeo inspect --raw "oci:/tmp/oci-image" | \
jq -c '[.manifests[]? | {arch: .platform.architecture, digest: .digest}] | sort_by(.arch)')
REMOTE=$(skopeo inspect --raw "docker://${IMAGE}" | \
jq -c '[.manifests[]? | {arch: .platform.architecture, digest: .digest}] | sort_by(.arch)')
if [[ "$LOCAL" == "$REMOTE" ]]; then
echo "OK: published manifest matches built artifact"
else
echo "ERROR: manifest mismatch between artifact and published image"
echo "Local: $LOCAL"
echo "Remote: $REMOTE"
exit 1
fi

rm -rf /tmp/oci-image
else
echo "Skipping image push for non-main branch ${{ github.ref }}"
fi
Expand Down