Fix silent host-loading failures found by real install - #1
Merged
Conversation
`claude plugin details` on an installed build reported `MCP servers (0)` and `Hooks (0)` while validate.py, `claude plugin validate --strict`, and a Cursor-side review all passed. Static schema checks cannot see this. Cause isolated with two-arm experiments on throwaway plugins. Host loading: - Claude Code discovers MCP only from a dot-prefixed `.mcp.json` at the plugin root. `"mcpServers": "./mcp.json"` and an inline object are both ignored. Ship `.mcp.json` alongside `mcp.json`, which Agent Plugins 1.0 and Cursor still require. - A Claude Code hook `command` must be one shell string; a list is dropped without error. `hooks/claude-code.json` now uses a string. - `hooks/cursor.json` -> `hooks/hooks.json` with `"version": 1`. Scanners look for the default filename; cursor.directory's auto-detect found 7 components and no hook under the old name. After: Skills 2, Agents 1, Hooks 1, MCP servers 1 on a real install. Validator (the gate that missed all of the above): - check_mcp_discovery: `.mcp.json` must exist and match `mcp.json` - check_hook_schemas: no list commands, Cursor file carries `version: 1` - both confirmed to fire by deliberately breaking each Listing copy: - 55 tools, not 59. Four billing tools are registered server-side but runtime-gated, so a connected client never sees them. - patches/0003 scrubs the internal tool name that survived 0002 in SKILL.md frontmatter and both antipattern references, and replaces named third-party platforms in SKILL.md's decision tree and reference table. SKILL.md is inlined verbatim into marketplace listings, so its text is public copy. Docs: - CHANGELOG: `Unreleased` sat below `1.0.0` while holding work already in the tree. Folded in. - PLATFORMS.md: recorded both loading rules; removed a paragraph claiming Devin has no plugin format that contradicted the matrix two lines above. Out of scope: - references/MIGRATION.md keeps competitor names on purpose — a migration guide has to name what you migrate from, and references are not inlined. - Cursor is still unverified by a live editor install. - sync-from-mcp.sh --check not run; claudecode-mcp-go is not cloned here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claude plugin detailson an installed build reportedMCP servers (0)andHooks (0)while validate.py,claude plugin validate --strict, and a Cursor-side review all passed. Static schema checks cannot see this. Cause isolated with two-arm experiments on throwaway plugins.Host loading:
.mcp.jsonat the plugin root."mcpServers": "./mcp.json"and an inline object are both ignored. Ship.mcp.jsonalongsidemcp.json, which Agent Plugins 1.0 and Cursor still require.commandmust be one shell string; a list is dropped without error.hooks/claude-code.jsonnow uses a string.hooks/cursor.json->hooks/hooks.jsonwith"version": 1. Scanners look for the default filename; cursor.directory's auto-detect found 7 components and no hook under the old name.After: Skills 2, Agents 1, Hooks 1, MCP servers 1 on a real install.
Validator (the gate that missed all of the above):
.mcp.jsonmust exist and matchmcp.jsonversion: 1Listing copy:
Docs:
Unreleasedsat below1.0.0while holding work already in the tree. Folded in.Out of scope: