fix: reuse referenced enum component types - #189
Merged
nikcio merged 1 commit intoSep 5, 2026
Merged
Conversation
nikcio
enabled auto-merge (squash)
September 5, 2026 14:28
Contributor
|
@geirsagberg-udir Thanks for this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$refschemas from inline-enum discovery and property emissionMessageTypeWhy
Microsoft.OpenApi exposes the referenced enum values through
OpenApiSchemaReference. The emitter therefore classified the reference as an inline enum, emitted bothMessageTypeandMessageType2, and usedMessageType2in the containing record.This changes generated property types from the property-derived enum name to the referenced component name. That can be source-breaking when consumers regenerate, but it removes an incorrect duplicate public type rather than preserving it behind a compatibility mode.
Verification
dotnet build --no-restore --configuration Releasedotnet test --no-build --configuration Release --verbosity normal(272 passed, 1 intentionally skipped)