fix: infer omitted enum schema types - #191
Merged
Merged
Conversation
nikcio
enabled auto-merge (squash)
September 6, 2026 10:12
Contributor
|
@geirsagberg-udir Thanks for this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stringwhen every non-null enum value is a stringintegerwhen every non-null enum value is an integral value supported by the generated C# enumtypeas authoritativeWhy
ASP.NET Core with
JsonStringEnumConvertercan emit component schemas with stringenumvalues but notype(dotnet/aspnetcore#61303). These currently fall through to an empty record. OpenAPI Generator 7.25.0 and NSwag 14.7.1 both infer a string enum for the same schema.A schema containing only
enumis valid, but enum values can technically mix JSON types. Inference is therefore limited to homogeneous values that map cleanly to the generator’s supported C# enum representations.Verification
dotnet build --no-restore --configuration Releasedotnet test --no-build --configuration Release --verbosity normal(278 passed, 1 intentionally skipped)