arm64: dts: npcm845: correct TIP RNG register size - #577
Open
helloxiling wants to merge 1 commit into
Open
Conversation
The TIP RNG client accesses three 32-bit registers at offsets 0, 4, and 8, but its DT resource includes a fourth scratchpad. Composite EAT uses that fourth register as scratchpad 24. Limit the RNG resource to the registers it owns so both clients can be described without overlapping MMIO resources. Signed-off-by: xilingsun <xilingsun@microsoft.com>
helloxiling
marked this pull request as ready for review
August 25, 2026 04:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TIP RNG driver accesses three 32-bit registers at offsets 0, 4, and 8 from
0xF0800E54, but its DT resource currently includes a fourth scratchpad.Reduce the resource size from
0x10to0x0c, leaving scratchpad 24 at0xF0800E60available to its actual owner.Motivation
Without this correction, TIP RNG and the Composite EAT client describe overlapping MMIO resources and one probe fails with
-EBUSY. This is an independent DTS ownership correction and does not enable Composite EAT.Validation
scripts/checkpatch.pl --strict: 0 errors, warnings, or checksgit diff --check: passnuvoton-npcm845-evb.dtbcompile underW=1: passThe emitted NPCM845 unit-address warnings are pre-existing and unrelated to the changed resource size.