Skip to content

Warn about phase labelling only above the water-oil contact - #7491

Open
GitPaean wants to merge 1 commit into
OPM:masterfrom
GitPaean:comp-equil-label-warning
Open

GitPaean wants to merge 1 commit into
OPM:masterfrom
GitPaean:comp-equil-label-warning

Conversation

@GitPaean

@GitPaean GitPaean commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

A single-zone compositional region (EQUIL item 10 = 1) warns when its composition does not vary across the gas-oil contact, as the flash then cannot label the phases on either side:

Equilibration region 1: the gas-oil contact at 2050 m lies inside a type-1 region, but the composition does not vary across the contact. Compositional variation is required for proper phase labeling.

The check looked at every cell of the region, including those below the water-oil contact, which hold water only. A region whose two contacts coincide has no liquid zone, yet it got the warning. The check now covers the hydrocarbon above the water-oil contact, so variation below that contact no longer counts either.

For a column from 2000 m to 2100 m with a constant composition and the water-oil contact at 2050 m:

Gas-oil contact Hydrocarbon below the gas-oil contact Before After
2050 m, on the water-oil contact none warning no warning
2030 m, above the water-oil contact 2030–2050 m warning warning

A gas-oil contact below the water-oil contact is rejected when EQUIL is read, so it does not reach this check. test_compequil covers both rows.

With coinciding contacts the cells below the gas-oil contact hold water
only, so a composition that does not vary across it needs no warning.
@GitPaean GitPaean added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Oct 3, 2026
@GitPaean
GitPaean marked this pull request as draft October 3, 2026 23:29
@GitPaean
GitPaean marked this pull request as ready for review October 3, 2026 23:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant