Improve data-file generation reliability - #54
Open
utsinboots wants to merge 2 commits into
Open
Conversation
Restored backups may skip empty res/<caserunname>/ folders, so writing the data file failed with a misleading error. Create the folder first. Fixes #504 (cherry picked from commit ff2e2215da3424ef87ae30163792ca84ed4d59d0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports two fixes previously merged in MUIOGO:
-Falls back to the parameter's default value when its configured value is unset, preventing invalid or missing values during data-file generation.
-Creates the case-run directory before writing
data.txt, preventing file generation from failing when the directory does not already exist.Testing
-Confirmed MUIO starts and a model can be loaded.
-Confirmed data-file generation works with these changes.