Validate required Excel sheets before import - #59
Open
utsinboots wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports required Excel worksheet validation previously merged in MUIOGO.
Importing a template with a missing required worksheet could raise a raw
KeyErrorwhen the code accessed that sheet. This change validates all required worksheets first and returns a clear error listing any missing sheets.Question?
This change includes
TECHGROUPin the required-sheet list, although the existing code treats it as optional and creates a default when it is absent. ShouldTECHGROUPbe required in MUIO, given that older templates without it would be rejected?