Skip to content

Prevent results tab crash for pre-v5.6 models - #62

Open
utsinboots wants to merge 1 commit into
OSeMOSYS:masterfrom
utsinboots:fix/pre-v56-results-indicators
Open

Prevent results tab crash for pre-v5.6 models#62
utsinboots wants to merge 1 commit into
OSeMOSYS:masterfrom
utsinboots:fix/pre-v56-results-indicators

Conversation

@utsinboots

Copy link
Copy Markdown

Summary

Ports a legacy-model compatibility fix previously merged in MUIOGO.

  • Pre-v5.6 models may not contain the osy-indicators field. The Results code previously passed the missing value into mergeAllIndicatorsGrouped(), causing TypeError: customIndicators is not iterable.
  • This change falls back to an empty indicator list and validates the input before iterating.
  • Fix Results tab crash on pre-v5.6 cases EAPD-DRB/MUIOGO#475

Testing
-Reproduced the error on unchanged MUIO when customIndicators was undefined.
-Verified the updated helper returns an empty {} result without throwing an exception.

(cherry picked from commit 4f2d87d5c11a4132b75beb7334c57740ca2d5e71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants