Skip to content

fix(website): correct Pages deployment action pin - #338

Open
ritiksah141 wants to merge 1 commit into
devfrom
fix/website-deploy-pages-pin
Open

fix(website): correct Pages deployment action pin#338
ritiksah141 wants to merge 1 commit into
devfrom
fix/website-deploy-pages-pin

Conversation

@ritiksah141

Copy link
Copy Markdown
Collaborator

Summary

Corrects the immutable actions/deploy-pages@v4.0.5 commit pin used by the website deployment workflow.

Why

Website builds on dev completed successfully, but the deployment job failed during action resolution because the configured commit does not exist in actions/deploy-pages.

Changes

  • Replaced the invalid deployment action SHA with the verified commit behind the official v4.0.5 tag
  • Preserved the pinned-action security model and existing deployment behavior
  • Made no website content or runtime changes

Verification

  • npm run check: passed for CMS-disabled and CMS-enabled builds, with 14 pages verified
  • actionlint .github/workflows/website.yml: passed
  • git diff --check: passed
  • Official actions/deploy-pages v4.0.5 tag SHA verified through the GitHub API
  • Commit is DCO-signed

Deployment after merge

The next push to dev, or a manual workflow dispatch from dev, will rebuild the website and retry GitHub Pages deployment. Repository administrators must still configure Settings > Pages > Source: GitHub Actions if Pages is not already enabled.

Signed-off-by: ritiksah141 <ritiksah141@gmail.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/deploy-pages d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e 🟢 5.8
Details
CheckScoreReason
Maintained🟢 45 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 4
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Code-Review🟢 10all changesets reviewed
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Fuzzing⚠️ 0project is not fuzzed
SAST🟢 7SAST tool detected but not run on all commits
Branch-Protection⚠️ 1branch protection is not maximal on development and all release branches

Scanned Files

  • .github/workflows/website.yml

@parthrohit22 parthrohit22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I pulled refs/tags/v4.0.5 from actions/deploy-pages and the new SHA (d6db9016…c0c03e) matches, while the old one 404s — so the deploy job was genuinely broken at action resolution. Change is correctly scoped, pin comment still lines up, no behavior change. LGTM 👍 approving

@Vishnu2707 Vishnu2707 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ritiksah141 ritiksah141 self-assigned this Sep 11, 2026

@TFT444 TFT444 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA pin looks correct for v4.0.5. LGTM.

@TFT444 TFT444 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is fully green. The Pages deployment action pin is correct and the fix is straightforward. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants