Fill out WIP TopNav, make it possible to preview with ?newnav - #3335
Fill out WIP TopNav, make it possible to preview with ?newnav#3335rosslovas wants to merge 3 commits into
Conversation
33241a9 to
a1fed36
Compare
| ## Octopus Command Line (CLI) | ||
|
|
||
| The Octopus CLI is a command line tool that builds on top of the [Octopus Deploy REST API](https://octopus.com/docs/octopus-rest-api). With the Octopus CLI, you can push your application packages for deployment as either zip or NuGet packages, and manage your environments, deployments, projects, and workers. | ||
| The Octopus CLI is a command line tool that builds on top of the [Octopus Deploy REST API](/docs/octopus-rest-api). With the Octopus CLI, you can push your application packages for deployment as either zip or NuGet packages, and manage your environments, deployments, projects, and workers. |
There was a problem hiding this comment.
Drive-by fixup just so these links work on staging sites
a1fed36 to
493709c
Compare
| box-shadow: 0 5px 30px rgba(0, 0, 0, 0.2); | ||
| background-color: var(--header-bg); | ||
| min-height: 82px; | ||
| min-height: var(--header-height); |
There was a problem hiding this comment.
Made this a variable because the new nav has a different height, and there are a few bits and pieces that were hardcoding the old 82px height.
| import '../scripts/theme-switcher'; | ||
| </script> | ||
|
|
||
| <style> |
There was a problem hiding this comment.
Made these scoped styles just like I recently did with Button. I intended to do this all along, but I couldn't do it when I first added this because our caching strategy was broken and CSS with a content-hash that no longer exists could be pointed to by an old cached HTML page. That's all fixed now.
| { label: 'API', href: '#' }, | ||
| { label: 'CLI', href: '#' }, | ||
| { label: 'Docs', href: '/docs' }, | ||
| { label: 'Learn', href: '#' }, // TODO: Make this a real link |
There was a problem hiding this comment.
Not sure just yet what this is supposed to point to, I think the others are good though
| { label: 'Docs', href: '/docs' }, | ||
| { label: 'Learn', href: '#' }, // TODO: Make this a real link | ||
| { label: 'API', href: '/docs/octopus-rest-api' }, | ||
| { label: 'CLI', href: '/docs/octopus-rest-api/cli' }, |
There was a problem hiding this comment.
I've assumed CLI means the CLI that talks to an Octopus Server instance over HTTP, not the CLI of the Octopus Server binary itself, which is only applicable to self-hosted
| data-theme-toggle-button | ||
| /> | ||
| <!-- TODO: Make this a real link --> | ||
| <Button label="Changelog" href="#" /> |
There was a problem hiding this comment.
Not sure what this is supposed to point to just yet, I couldn't actually find release notes for non-self-hosted releases available anywhere
493709c to
8becccb
Compare
8becccb to
36b5b53
Compare
1 participant
Summary
This PR fills out some of the functionality in the new
TopNavcomponent:This PR also adds the ability for you to add
?newnavto any URL and it will temporarily replace the old header with the new work-in-progressTopNav. It will remember this for an hour before automatically reverting back to the old one, or you can add?newnav=0to go back to the old one at any point. This will let us play with it in production before it's fully ready to go.