fix(build-multiarch): update stale Dockerfile.new entries to Dockerfile - #91
Merged
Merged
Conversation
9 of the 12 IMAGES table entries still pointed at Dockerfile.new,
which none of those repos have had since their Dockerfile.new ->
Dockerfile renames. The script's own existence check makes this fail
loudly ("Dockerfile not found") rather than silently, but it meant
./scripts/build-multiarch.sh with no filter currently failed for 9 of
12 images.
Verified each of the 9 affected repos (workflow-bundles, tool-images,
tes, rag, dev-hub, model-registry, toolserver, lims, control-center)
has a plain Dockerfile at its root and no Dockerfile.new, both before
and immediately before this edit. videos/sdk/app entries already said
Dockerfile and are untouched.
Fixes #90
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0119F1kccNV19VuMnemXPcXL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
What
9 of the 12 entries in
scripts/build-multiarch.sh'sIMAGESconfig table pointed atDockerfile.new, which none of those repos have had since their ownDockerfile.new→Dockerfilerenames. The script's[[ -f $df_path ]]check makes this fail loudly ("Dockerfile not found") rather than silently building the wrong thing, but in practice./scripts/build-multiarch.shwith no filter currently fails for 9 of 12 images.Verified before this change
Each of the 9 affected repos' root confirmed to have a plain
Dockerfileand noDockerfile.new, checked twice (once during the original audit, once immediately before this edit):videos,sdk,appentries already saidDockerfileand are untouched.Diff