Skip to content

Defer missing clayer file handling during context parsing - #2580

Open
brondani wants to merge 1 commit into
mainfrom
defer-missing-clayer-file
Open

Defer missing clayer file handling during context parsing#2580
brondani wants to merge 1 commit into
mainfrom
defer-missing-clayer-file

Conversation

@brondani

@brondani brondani commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Record missing .clayer.yml files in m_missingFiles instead of attempting to parse them.
  • Skip "to-be-generated" file: do not report error if missing layer file is listed as an output of an execute node.
  • Add unit-test coverage verifying missing clayer files are deferred and do not fail context-layer parsing.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Generate yml files when layer files are missing.
Do not report error if missing layer file is listed
as an output of an execute node.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, aligns with the stated behavior for deferring missing layer handling, and includes targeted unit test coverage for the new flow.

Pull request overview

This PR adjusts ProjMgr’s context-layer parsing so missing explicit .clayer.yml files no longer cause an immediate parsing failure; instead they are recorded as missing and handled later, enabling downstream generation steps to proceed (per issue #2578).

Changes:

  • Defer handling of missing explicit layer files by recording them in m_missingFiles and skipping parsing in ParseContextLayers.
  • Add a unit test ensuring missing .clayer.yml files are deferred (no parse failure, no context.clayers entry) and are tracked in m_missingFiles.
File summaries
File Description
tools/projmgr/src/ProjMgrWorker.cpp Defers missing explicit layer file handling by tracking missing files instead of parsing.
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp Adds unit test validating deferred handling and missing-file tracking for absent .clayer.yml.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@brondani
brondani marked this pull request as ready for review August 31, 2026 10:59
@brondani
brondani requested a review from soumeh01 August 31, 2026 10:59
@github-actions

Copy link
Copy Markdown

Test Results

  2 files   14 suites   14m 57s ⏱️
482 tests 482 ✅ 0 💤 0 ❌
964 runs  964 ✅ 0 💤 0 ❌

Results for commit bbf31d4.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.13%. Comparing base (fdcbbe9) to head (bbf31d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   72.16%   72.13%   -0.03%     
==========================================
  Files         185      185              
  Lines       30253    30255       +2     
  Branches    17845    17846       +1     
==========================================
- Hits        21831    21824       -7     
- Misses       6110     6116       +6     
- Partials     2312     2315       +3     
Flag Coverage Δ
projmgr-cov 87.94% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.40% <100.00%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants