Defer missing clayer file handling during context parsing - #2580
Conversation
Generate yml files when layer files are missing. Do not report error if missing layer file is listed as an output of an execute node.
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, aligns with the stated behavior for deferring missing layer handling, and includes targeted unit test coverage for the new flow.
Pull request overview
This PR adjusts ProjMgr’s context-layer parsing so missing explicit .clayer.yml files no longer cause an immediate parsing failure; instead they are recorded as missing and handled later, enabling downstream generation steps to proceed (per issue #2578).
Changes:
- Defer handling of missing explicit layer files by recording them in
m_missingFilesand skipping parsing inParseContextLayers. - Add a unit test ensuring missing
.clayer.ymlfiles are deferred (no parse failure, nocontext.clayersentry) and are tracked inm_missingFiles.
File summaries
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrWorker.cpp | Defers missing explicit layer file handling by tracking missing files instead of parsing. |
| tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp | Adds unit test validating deferred handling and missing-file tracking for absent .clayer.yml. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results 2 files 14 suites 14m 57s ⏱️ Results for commit bbf31d4. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 72.16% 72.13% -0.03%
==========================================
Files 185 185
Lines 30253 30255 +2
Branches 17845 17846 +1
==========================================
- Hits 21831 21824 -7
- Misses 6110 6116 +6
- Partials 2312 2315 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
Changes
.clayer.ymlfiles inm_missingFilesinstead of attempting to parse them.Checklist