[ctrace] Align trace-run metadata with specification - #2581
[ctrace] Align trace-run metadata with specification#2581thorstendb-ARM wants to merge 4 commits into
Conversation
Test Results 4 files 4 suites 1s ⏱️ Results for commit 55ba90e. ♻️ This comment has been updated with latest results. |
soumeh01
left a comment
There was a problem hiding this comment.
svdconv-cov shows a -0.44% coverage change although this PR does not modify SVDConv.
The SVDConv workflow is path-filtered and is not run for these ctrace only changes. The svdconv-cov Codecov flag has carryforward: true, so this appears to be a carried-forward/stale coverage comparison rather than a coverage regression introduced by this PR.
carryforward: true is useful for our use case as the repository is large. SVDConv wasn't tested this time, so It will carry forward its previous coverage. Otherwise it will complain about the 0 coverage/missing coverage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
==========================================
- Coverage 72.30% 72.18% -0.12%
==========================================
Files 185 185
Lines 30285 30275 -10
Branches 17870 17860 -10
==========================================
- Hits 21897 21854 -43
- Misses 6079 6109 +30
- Partials 2309 2312 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
@soumeh01 , does the failing coverage check gate this PR once a reviewer approved? |
Seems like it doesn't I just approved and it allows me to merge it. |
jreineckearm
left a comment
There was a problem hiding this comment.
Just one question, will give it a try next
| "supported data.symbol-type values are 'unsigned int', 'signed int', and 'float'; " | ||
| "data.symbol-size must be 1, 2, or 4, and float requires size 4"; | ||
| "supported data-type values are 'unsigned', 'signed', and 'float'; " | ||
| "size must be 1, 2, or 4, and float requires size 4"; |
There was a problem hiding this comment.
How would a full message with this look like? Does it make clear that this is only CTF generation?
jreineckearm
left a comment
There was a problem hiding this comment.
Tested, still works as expected with the new nodes written by pyTS.
Good to get merged (I can't, I don't have the rights).
|
@thorstendb-ARM All comments must be resolved to merge this. |
Fixes
Changes
address,size, anddata-typefields.unsigned,signed, andfloatdata types.ctrace-setup.data.sizewhen reference-levelsizeis absent.data#<index>references from instruction-control references so that only data references create decoded data sources.Checklist