Skip to content

Extend MLOps configuration variable expansion and model properties - #2583

Merged
brondani merged 2 commits into
mainfrom
extend-mlops-configuration-variable
Sep 1, 2026
Merged

Extend MLOps configuration variable expansion and model properties#2583
brondani merged 2 commits into
mainfrom
extend-mlops-configuration-variable

Conversation

@brondani

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Allow additional MLOps model properties: parse, preserve and emit custom mlops.model properties in generated cbuild-mlops files.
  • Expand variables in NPU settings, Vela options, model name and custom model properties.
  • Update the extended MLOps fixture and reference output to cover resolved configuration values and an additional model property.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Allow additional `key: value` pairs (string or numeric) `model` properties and emit them in the generated MLOps file.
Resolve variables in NPU, Vela and model settings.
@brondani
brondani force-pushed the extend-mlops-configuration-variable branch from 5de8dd6 to 279d4e9 Compare August 31, 2026 14:21
@brondani
brondani requested a lite review from Copilot August 31, 2026 14:33
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

Test Results

  2 files   14 suites   16m 44s ⏱️
481 tests 481 ✅ 0 💤 0 ❌
962 runs  962 ✅ 0 💤 0 ❌

Results for commit a626963.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Undefined $Var$ placeholders are not currently expanded to empty strings as required, which can lead to incorrect generated output (notably mlops.npu.macs being emitted as 0).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Extends ProjMgr’s MLOps YAML handling to support variable expansion across more fields and to allow arbitrary extra properties under mlops.model, emitting them into generated *.cbuild-mlops.yml outputs.

Changes:

  • Added parsing/propagation of custom mlops.model properties into generated cbuild-mlops files.
  • Expanded access-sequence variables in NPU settings, Vela selectors/options, model name, and custom model properties.
  • Updated schema and test fixtures/reference outputs to cover the extended behavior.
File summaries
File Description
tools/projmgr/test/data/MLOps/ref/extended.cbuild-mlops.yml Updates reference output to include resolved model name and an additional model property.
tools/projmgr/test/data/MLOps/extended.csolution.yml Updates fixture to use $...$ variables in MLOps settings and adds corresponding variable definitions.
tools/projmgr/src/ProjMgrYamlParser.cpp Parses NPU MACs as string (for variables) and collects additional mlops.model key/value properties.
tools/projmgr/src/ProjMgrMlops.cpp Expands variables for more MLOps fields and carries custom model properties through to output generation.
tools/projmgr/src/ProjMgrCbuildMlops.cpp Emits custom mlops.model additional properties into the generated YAML.
tools/projmgr/schemas/common.schema.json Updates schema to allow numeric values where variables/custom properties may appear.
tools/projmgr/include/ProjMgrParser.h Adds storage for additional model properties in parsed MLOps data model.
tools/projmgr/include/ProjMgrMlops.h Adds storage for additional model properties in collected/emitted MLOps data model.
Review details
  • Files reviewed: 8/8 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/projmgr/src/ProjMgrMlops.cpp
@brondani
brondani marked this pull request as ready for review August 31, 2026 15:30
@brondani
brondani requested a review from soumeh01 August 31, 2026 15:30
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.17%. Comparing base (fdcbbe9) to head (a626963).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrMlops.cpp 92.85% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
+ Coverage   72.16%   72.17%   +0.01%     
==========================================
  Files         185      185              
  Lines       30253    30279      +26     
  Branches    17845    17865      +20     
==========================================
+ Hits        21831    21855      +24     
- Misses       6110     6111       +1     
- Partials     2312     2313       +1     
Flag Coverage Δ
projmgr-cov 88.05% <94.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrParser.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgrCbuildMlops.cpp 95.91% <100.00%> (+0.17%) ⬆️
tools/projmgr/src/ProjMgrYamlParser.cpp 85.12% <100.00%> (+0.06%) ⬆️
tools/projmgr/src/ProjMgrMlops.cpp 82.94% <92.85%> (+0.71%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani
brondani merged commit 0b1f01d into main Sep 1, 2026
31 checks passed
@brondani
brondani deleted the extend-mlops-configuration-variable branch September 1, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants