Skip to content

[svdconv] Correct enum combo width warning - #2584

Merged
thorstendb-ARM merged 1 commit into
mainfrom
svdconv-fix-m227-enum-limit
Aug 31, 2026
Merged

[svdconv] Correct enum combo width warning#2584
thorstendb-ARM merged 1 commit into
mainfrom
svdconv-fix-m227-enum-limit

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Fixes

Report the actual field width and the six-bit combo limit instead of the incorrect 256-element maximum. Add integration coverage for the six- and seven-bit boundary.
See #2569

Changes

  • Message M227

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Report the actual field width and the six-bit combo limit instead of the incorrect 256-element maximum. Add integration coverage for the six- and seven-bit boundary.
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.31%. Comparing base (fdcbbe9) to head (feedf62).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
+ Coverage   72.16%   72.31%   +0.15%     
==========================================
  Files         185      185              
  Lines       30253    30257       +4     
  Branches    17845    17849       +4     
==========================================
+ Hits        21831    21880      +49     
+ Misses       6110     6072      -38     
+ Partials     2312     2305       -7     
Flag Coverage Δ
svdconv-cov 47.26% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/svdconv/SVDGenerator/src/SfdData_SingleItems.cpp 51.36% <100.00%> (+3.69%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Test Results

 4 files  10 suites   0s ⏱️
31 tests 31 ✅ 0 💤 0 ❌
62 runs  62 ✅ 0 💤 0 ❌

Results for commit feedf62.

@thorstendb-ARM
thorstendb-ARM requested a review from jkrech August 31, 2026 14:27

@jkrech jkrech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorstendb-ARM
thorstendb-ARM merged commit fd7e0e9 into main Aug 31, 2026
26 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the svdconv-fix-m227-enum-limit branch August 31, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants