Bug: Failed concept merges do not appear in notifications

[filiperochalopes]

User story

As a curator, I want failed background concept merges to appear in the notification center so I know when a merge was rolled back and can investigate or retry it.

Use case

A concept merge runs in the background and OCL rejects one or more writes. The merge is rolled back, but the curator receives no notification and may incorrectly assume the operation is still processing or was successful.

Requirements

• Record a concept_merge.failed notification when a background concept merge fails or is rolled back.
• Include a link to the failed merge or its merge history.
• Preserve the existing merge and OCL write-log details as the notification evidence.

Acceptance criteria

• Given a concept merge is rolled back after an OCL rejection, when the background job finishes, then an error notification appears in the user's notification center.
• Given a concept merge fails unexpectedly, when the background job finishes, then an error notification appears in the user's notification center.
• The notification identifies the affected merge and does not change the existing rollback behavior.

More details (collapsible)

Investigation evidence

The notification registry already defines concept_merge.failed as a persistent error event with browser push enabled.

However, the concept merge execution path in apply_concept_merge / run_merge_job updates the merge job and item status but does not call notification_service.record.

Recent examples:

• 118305 → 118306: rolled back after OCL returned HTTP 400 because a name already existed for the same source and locale.
• 115801 → 115800: rolled back for the same type of OCL rejection.

The failures are visible in the merge history and ocl_concept_write_logs, but not in the notification center.

[ocl-automation]

Automated Triage — 2026-09-22

Dimension	Score
Complexity	2
Scope	2
Clarity	4
Dependency	2
Risk	2

Decision: decision/ai-ready
Type: type/bug
Signals: signal/quick-win, signal/low-risk, signal/small-scope, signal/well-specified

Well-specified bug with clear acceptance criteria and investigation evidence pinpointing the missing notification_service.record call in apply_concept_merge/run_merge_job; fix is localized to a couple of files using an already-defined notification registry entry, so complexity, scope, and dependency are low, with modest risk since it only affects notification visibility, not the core rollback logic.

---

Generated by ticket-triage pipeline v3. Model: anthropic/claude-sonnet-5 (openrouter).

[filiperochalopes]

Implemented the remaining Notification Center part of this fix.

What QA should see

When a background concept merge fails (including an OCL rejection followed by rollback, or an unexpected failure), its error notification in Notifications now has an Open concept link.

QA checks

Please use the local/homologation OCL environment only:

1. Start a merge that is expected to fail.
2. Wait for the background job to reach its terminal failed/rolled-back state.
3. Open the notification bell, then Notifications.
4. Find the error notification named Merge failed: <source> into <target>.
5. Expand the notification. Confirm that it shows the failure evidence and an Open concept link.
6. Select Open concept. It should take you to the surviving/target concept in Concept Manager.
7. Confirm that the failure reason is still visible and that the merge remains rolled back; this change does not alter merge or rollback behavior.

The UI only exposes this stored action for failed merge notifications and only accepts internal CIEL Lab destinations.

Verification completed locally: TypeScript check, frontend lint, 298 frontend unit tests, 27 merge-notification backend regression tests, plus a browser check of the notification link and its navigation.

[filiperochalopes]

/uat @askanter