Skip to content

TBv3: a user's Repositories tab may keep the previous user's filter values #2823

Description

@paynejd

Summary

Probably the same bug as #2819, on user profile pages. One UserHome instance serves every /users/:user/... page, and its Repositories tab renders a Search that isn't keyed per user. Moving from one user's Repositories tab to another's in the same tab should carry the first user's filter values into the second user's panel.

Not reproduced, because user pages need sign-in. The organization page had the same structure and did leak: going from CIEL's Repositories tab to Regenstrief's left 25 CIEL values greyed out at 0 (locales, source types, the openmrs validation schema). The #2819 fix covers the organization page.

Acceptance criteria

  • Moving between two users' Repositories tabs in the same tab shows only the second user's filter values, with no reload.

Notes

Same fix as the organization page in #2819: key UserHome by :user. Its route in src/components/app/App.jsx uses AuthenticationRequiredRoute, which only accepts component, so pass a small wrapper that renders <UserHome key={match.params.user} />, or let the route take a key.

Related: #2819.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions