fix(filters): stabilize filters, use reported sample rate, support comma values - #291
Open
o-bagge wants to merge 1 commit into
Open
fix(filters): stabilize filters, use reported sample rate, support comma values#291o-bagge wants to merge 1 commit into
o-bagge wants to merge 1 commit into
Conversation
…mma values Prefer the device-reported sensor frequency when deriving live chart filter bounds, falling back to the selected UI value only when no reported value is available. This keeps cutoff/notch limits aligned with the frequency actually applied on the device and avoids stale local selections. Also guard IIR filter stages against non-finite output so NaN/Infinity values do not reach the chart, and accept comma decimal input without rewriting the field text while the user is editing.
Contributor
|
Visit the preview URL for this PR (updated for commit 1518f4a): https://open-earable-web--pr291-fix-sensor-chart-fil-pc4ze482.web.app (expires Tue, 22 Sep 2026 11:50:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c7397c11177c71d8d81172cea9365829823fb41c |
Contributor
PR Build Artifacts
Full workflow run: https://github.com/OpenEarable/app/actions/runs/32844053652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290
Prefer the device-reported sensor frequency when deriving live chart filter bounds, falling back to the selected UI value only when no reported value is available. This keeps cutoff/notch limits aligned with the frequency actually applied on the device and avoids stale local selections.
Also guard IIR filter stages against non-finite output so NaN/Infinity values do not reach the chart, and accept comma decimal input without rewriting the field text while the user is editing.