Skip to content

Remove Font Awesome Pro kit from contributors page - #747

Open
JpMaxMan wants to merge 1 commit into
masterfrom
fix/remove-fontawesome-pro-kit
Open

Remove Font Awesome Pro kit from contributors page#747
JpMaxMan wants to merge 1 commit into
masterfrom
fix/remove-fontawesome-pro-kit

Conversation

@JpMaxMan

@JpMaxMan JpMaxMan commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Why

The Foundation's Font Awesome Pro subscription lapses today and is not being renewed, so kit.fontawesome.com/9438df25f9.js will stop serving.

A scan of this repository and of the live sites found the kit in exactly one place: /contributors/corporate/. Nothing else on openinfra.org loads a kit, and neither does openstack.org or superuser.openinfra.dev.

What was actually using it

The sort header on that page renders three icons:

? <i className="fa fa-chevron-down sort-icon" />   // FA4
: <i className="fa fa-chevron-up sort-icon" />     // FA4
: <i className="fas fa-sort sort-icon" />          // FA5 — needed the kit

Only the unsorted state used Font Awesome 5 syntax, and that single icon is the entire reason the kit was loaded.

fa-sort is a free icon and already ships in Font Awesome 4.7, which Layout.js loads on every page. So switching that one icon from fas to fa removes the last dependency on the kit.

Change

  • fas fa-sortfa fa-sort, making it consistent with the two sibling icons
  • Remove the <Helmet> block that loaded the kit script
  • Remove the now-unused Helmet import

No new dependency is added.

Visual impact

None expected. In _contributors.scss, .fa.sort-icon and .sort-icon set the same opacity and float, and every other property comes from .sort-icon, which matches regardless of which Font Awesome class the element carries. Adding the fa class is also what supplies the glyph once the kit is gone — previously that came from the kit's fas class.

Verification

The JSX parses cleanly and fa-sort is confirmed present in the Font Awesome 4.7 stylesheet the site already loads.

Please eyeball the sort icons on /contributors/corporate/ in the deploy preview — all three states, unsorted / ascending / descending. That is the one thing worth a human look, and the deploy preview on this PR will show it.

Out of scope, but worth filing separately

Both openinfra.org and openstack.org still depend on Font Awesome 4.7, released in 2016 and long end-of-life, loaded from maxcdn.bootstrapcdn.com — BootstrapCDN's retired domain. It currently still responds, but it is an unmaintained third-party dependency on the critical path of every page across two sites. Migrating to self-hosted or inline SVG icons is worth doing, but it touches many more files and deserves its own change with proper visual review rather than being rushed alongside a billing deadline.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Uz3HpgshDPXb5GL7cdYZJh

Summary by CodeRabbit

  • Bug Fixes
    • Updated the contributors page sort icon styling for improved compatibility.
    • Removed the embedded FontAwesome kit script from the page.

The Foundation's Font Awesome Pro subscription lapses today and is not
being renewed, so the kit script will stop serving.

The contributors page was the only place in the site that loaded a Pro
kit, and it did so for a single icon. Its sort header renders three
icons: fa-chevron-down and fa-chevron-up in Font Awesome 4 syntax, and
fa-sort in Font Awesome 5 syntax, which is what required the kit.

fa-sort is a free icon and already exists in Font Awesome 4.7, which
Layout.js loads on every page. Switching that one icon from "fas" to
"fa" removes the only dependency on the kit, so the script can go.

No visual change is expected. Both .fa.sort-icon and .sort-icon in
_contributors.scss set the same opacity and float, and the remaining
properties come from .sort-icon, which matches regardless of which Font
Awesome class the element carries. Adding the "fa" class is also what
supplies the glyph once the kit is no longer loaded.

The Helmet import is removed with its only usage.

Note this does not change openstack.org, which uses self-hosted Font
Awesome 4 free and is unaffected by the Pro subscription.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uz3HpgshDPXb5GL7cdYZJh
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ac05da84-1b46-4eb5-8635-0abb7bbdfe66

📥 Commits

Reviewing files that changed from the base of the PR and between d084a30 and 82232be.

📒 Files selected for processing (1)
  • src/templates/contributors-page.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The contributor page removes the FontAwesome kit injection and updates the unsorted-column sort icon class.

Changes

Contributor table

Layer / File(s) Summary
Sort indicator update
src/templates/contributors-page.js
The unsorted-column sort icon changes from fas fa-sort to fa fa-sort. The react-helmet import and FontAwesome kit script block are removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 82232

This updates the contributor table’s unsorted sort icon to use the already-loaded Font Awesome stylesheet and removes the unnecessary external kit. No remaining merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the Font Awesome Pro kit from the contributors page.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-fontawesome-pro-kit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JpMaxMan

JpMaxMan commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Verified on the deploy preview: https://deploy-preview-747--openinfra-dev.netlify.app/contributors/corporate/

Checked in Chrome against the built page, so a reviewer shouldn't need to repeat this.

Kit is gone

  • kit.fontawesome.com references in the served HTML: 0
  • Kit <script> tags present in the DOM: 0
  • font-awesome/4.7.0/css/font-awesome.min.css still loaded, as expected from Layout.js

All three sort states render

State Class rendered Result
Unsorted fa fa-sort sort-icon double-arrow, on both columns
Ascending fa fa-chevron-up sort-icon renders
Descending fa fa-chevron-down sort-icon renders

Every icon resolves to font-family: FontAwesome with a non-empty ::before glyph and non-zero dimensions (9.16 x 16 px), so the glyphs are coming from Font Awesome 4 rather than falling back to a blank box.

Sorting behaviour is unaffected: clicking Company Name once sorts ascending (ABT Limitel, ADII Research and Applications, ADOC International) and twice sorts descending (100 Percent IT Ltd, 99Cloud, 6WIND).

One thing I could not check

This compares the built page against how the code should render, not against a before-and-after of production. If the Pro kit's fa-sort glyph differed subtly in weight or shape from Font Awesome 4's, that would not show up here. Worth a quick glance at the preview if that matters; otherwise the icon is in the same position, at the same size and opacity, in all three states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant