Remove Font Awesome Pro kit from contributors page - #747
Conversation
The Foundation's Font Awesome Pro subscription lapses today and is not being renewed, so the kit script will stop serving. The contributors page was the only place in the site that loaded a Pro kit, and it did so for a single icon. Its sort header renders three icons: fa-chevron-down and fa-chevron-up in Font Awesome 4 syntax, and fa-sort in Font Awesome 5 syntax, which is what required the kit. fa-sort is a free icon and already exists in Font Awesome 4.7, which Layout.js loads on every page. Switching that one icon from "fas" to "fa" removes the only dependency on the kit, so the script can go. No visual change is expected. Both .fa.sort-icon and .sort-icon in _contributors.scss set the same opacity and float, and the remaining properties come from .sort-icon, which matches regardless of which Font Awesome class the element carries. Adding the "fa" class is also what supplies the glyph once the kit is no longer loaded. The Helmet import is removed with its only usage. Note this does not change openstack.org, which uses self-hosted Font Awesome 4 free and is unaffected by the Pro subscription. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uz3HpgshDPXb5GL7cdYZJh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe contributor page removes the FontAwesome kit injection and updates the unsorted-column sort icon class. ChangesContributor table
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the contributor table’s unsorted sort icon to use the already-loaded Font Awesome stylesheet and removes the unnecessary external kit. No remaining merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Verified on the deploy preview: https://deploy-preview-747--openinfra-dev.netlify.app/contributors/corporate/ Checked in Chrome against the built page, so a reviewer shouldn't need to repeat this. Kit is gone
All three sort states render
Every icon resolves to Sorting behaviour is unaffected: clicking Company Name once sorts ascending ( One thing I could not check This compares the built page against how the code should render, not against a before-and-after of production. If the Pro kit's |
Why
The Foundation's Font Awesome Pro subscription lapses today and is not being renewed, so
kit.fontawesome.com/9438df25f9.jswill stop serving.A scan of this repository and of the live sites found the kit in exactly one place:
/contributors/corporate/. Nothing else on openinfra.org loads a kit, and neither does openstack.org or superuser.openinfra.dev.What was actually using it
The sort header on that page renders three icons:
Only the unsorted state used Font Awesome 5 syntax, and that single icon is the entire reason the kit was loaded.
fa-sortis a free icon and already ships in Font Awesome 4.7, whichLayout.jsloads on every page. So switching that one icon fromfastofaremoves the last dependency on the kit.Change
fas fa-sort→fa fa-sort, making it consistent with the two sibling icons<Helmet>block that loaded the kit scriptHelmetimportNo new dependency is added.
Visual impact
None expected. In
_contributors.scss,.fa.sort-iconand.sort-iconset the sameopacityandfloat, and every other property comes from.sort-icon, which matches regardless of which Font Awesome class the element carries. Adding thefaclass is also what supplies the glyph once the kit is gone — previously that came from the kit'sfasclass.Verification
The JSX parses cleanly and
fa-sortis confirmed present in the Font Awesome 4.7 stylesheet the site already loads.Please eyeball the sort icons on
/contributors/corporate/in the deploy preview — all three states, unsorted / ascending / descending. That is the one thing worth a human look, and the deploy preview on this PR will show it.Out of scope, but worth filing separately
Both openinfra.org and openstack.org still depend on Font Awesome 4.7, released in 2016 and long end-of-life, loaded from
maxcdn.bootstrapcdn.com— BootstrapCDN's retired domain. It currently still responds, but it is an unmaintained third-party dependency on the critical path of every page across two sites. Migrating to self-hosted or inline SVG icons is worth doing, but it touches many more files and deserves its own change with proper visual review rather than being rushed alongside a billing deadline.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uz3HpgshDPXb5GL7cdYZJh
Summary by CodeRabbit