Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 32.17% 32.17%
=======================================
Files 71 71
Lines 2601 2601
=======================================
Hits 837 837
Misses 1764 1764
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Kyle-Ye
commented
Aug 25, 2026
| public typealias OAGValue = IAGChangedValue | ||
| public typealias OAGValueOptions = IAGValueOptions | ||
|
|
||
| #if OPENATTRIBUTEGRAPH_COMPUTE_BINARY |
Member
Author
There was a problem hiding this comment.
This is strange due to a current Compute release issue. I really do not want to add it. cc @jcmosc
- Compute removed such conformance in
3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4. (I did not got the reason. But this is a small thing and I add patch it here if Compute do have a need to remove it.) - The weird thing is the 0.5.1 tag.
The source code point to b66dc81e2d16687b83769c492cd22ab699f28c0b which does not contain 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4. So I do not need this patch.
But the 0.5.1 binary looks to be build by main after merge 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4 which is 1fbf330926ffcebf74a9ea7e6dcd7957098f85c1 and includes 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4. So there is a mismatch here.
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation