Skip to content

Update Compute integration to 0.5.1 - #236

Open
Kyle-Ye wants to merge 1 commit into
mainfrom
bump/oag
Open

Update Compute integration to 0.5.1#236
Kyle-Ye wants to merge 1 commit into
mainfrom
bump/oag

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • update the default Compute source and binary version to 0.5.1 and use the matching binary checksum
  • adapt the Compute shims to the updated input and graph tracing APIs
  • restore the weak-attribute hashable conformance when consuming the binary distribution

Validation

  • validated OpenSwiftUI UI test target compilation against both the Compute 0.5.1 source and binary distributions

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.17%. Comparing base (480e30e) to head (41d96a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   32.17%   32.17%           
=======================================
  Files          71       71           
  Lines        2601     2601           
=======================================
  Hits          837      837           
  Misses       1764     1764           
Flag Coverage Δ
ios 32.19% <ø> (ø)
macos 10.15% <ø> (ø)
ubuntu 12.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

public typealias OAGValue = IAGChangedValue
public typealias OAGValueOptions = IAGValueOptions

#if OPENATTRIBUTEGRAPH_COMPUTE_BINARY

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange due to a current Compute release issue. I really do not want to add it. cc @jcmosc

  1. Compute removed such conformance in 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4. (I did not got the reason. But this is a small thing and I add patch it here if Compute do have a need to remove it.)
  2. The weird thing is the 0.5.1 tag.

The source code point to b66dc81e2d16687b83769c492cd22ab699f28c0b which does not contain 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4. So I do not need this patch.

But the 0.5.1 binary looks to be build by main after merge 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4 which is 1fbf330926ffcebf74a9ea7e6dcd7957098f85c1 and includes 3c955fe3cff8ae29fa5a66ae087c0763d7f1d1c4. So there is a mismatch here.

@tuist

tuist Bot commented Aug 25, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenAttributeGraph-Package 0 % 90 0 90 36e6fff51

Builds 🔨

Scheme Status Duration Commit
OpenAttributeGraph 10.0s 36e6fff51
OpenAttributeGraph-Package 1m 7s 36e6fff51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant